- Issue created by @jwilson3
- 🇩🇪Germany gbyte Berlin
Generally XML sitemaps are not meant to be viewed by humans. You can tell by the fact they themselves are not indexed/included as search results. While this module offers programmatic customizations of XSL output, the default XSL markup is only helpful for debugging purposes and has no effect on the module's intended functionality. Hence not a bug.
I'm happy to review merge requests.
- 🇪🇨Ecuador jwilson3
Thanks for agreeing to review MRs! I of course humbly disagree with reclassifying this and the sister tickets away from being bugs, but of course you're the maintainer and free to run your queue how you like.
From my perspective, if it can be displayed in a browser — regardless of who views it or for what purpose — then it needs to pass accessibility.
Developers, site owners, and power users alike can use Sitemap.xml in browser for varying purposes, not only debugging. But as further support for why the debugging argument doesn't hold, Drupal has committed to making their codebase adhere to accessibility coding standards → , which only Developers doing their day job will ever see.
I'll spare you the copy/pasta to the other two sister issues to reply to the same comment you left there. If I do get approval for spending time on these fixes from client, or some internal contrib time, I'll see what I can do to submit an MR.
Thanks again!
- First commit to issue fork.
- Merge request !55Issue #3340003: Accessibility: "Language is missing or invalid" in sitemap.xml XSL transform → (Closed) created by duaelfr
- Status changed to Needs review
almost 2 years ago 10:26am 9 February 2023 - 🇫🇷France duaelfr Montpellier, France
I'd add that people using Assistive Technologies are also devs/site builders therefore they need to be able to debug their sitemaps too.
- 🇪🇨Ecuador jwilson3
Thanks for jumping in @DuaelFr!
https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/55/diffs
The changes in the MR diff look exactly like what I expected to see.
Tested locally on a client site, and using Chrome Developer Console Inspector the
<html>tag now contains a lang="en" attribute (depicted in the attached screenshot).RTBC.
- Status changed to RTBC
almost 2 years ago 7:48pm 9 February 2023 - First commit to issue fork.
- last update
about 1 year ago 32 pass -
walkingdexter →
authored f4a54b14 on 4.x
Issue #3340003 by duaelfr, jwilson3, gbyte, walkingdexter: Accessibility...
-
walkingdexter →
authored f4a54b14 on 4.x
- Status changed to Fixed
2 months ago 3:52pm 13 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.