Drupal 10 compatibility fixes

The last submitted patch, 3: 3339791-3.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Here's a first pass at removing MediaRevisionAccessCheck. The work for that was going to be split of into 📌 Remove MediaRevisionAccessCheck Closed: duplicate however Drupal 10 removed core's MediaRevisionAccessCheck our hand has been forced and this needs to happen now.

I've based this off of what was done for the 2.1 branch here, so far with no changes to that approach.

The last submitted patch, 5: 3339791-5.patch, failed testing. View results →

The last submitted patch, 7: 3339791-7.patch, failed testing. View results →

Attached is a much better crack at bringing the access check in line with core and other implementations (e.g. block_content_revision_ui and link_revision_ui).

The last submitted patch, 9: 3339791-9.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

This should pass, updates the revert message format for D10.

The last submitted patch, 11: 3339791-11.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

#11 passes for me locally on D10.0. Odd, can't see what would have changed in D10.1. Making the check more generic, I still think it's perfectly fine.

Some additional cleanups in MediaRevisionsUiTest, matches what's in the 2.x branch as well.

This also bumps the min version of Drupal core to 10.1 as that's where ✨ Implement a generic revision UI Fixed landed. I think if you're using this on 10.0, as we will be, you should be ok to alter this and relax this back to 10.0 yourself.

you might still need to prevent revert/delete of latest revision. Tests? (ensure latest not revertable/deletable?)

assert at top of media_revisions_ui_media_access can be removed.

@dpi thanks for the review!

Here's the changes you requested.

Nice work!

Thanks!

As this requires Drupal 10.1 I think it makes sense to hold off cutting a 3.0.0 release until that is out.

Thanks for the great work on this!

Unfortunately, merging these D10 compatibility fixes with only Drupal 10.1 support in the info.yml break the option to use the 3.x version of Media Revision UI in Drupal 9.5 with the core patch for the generic revisions UI.

We have a project in which we are preparing for an upgrade to Drupal 10 but because this is a very large site we are not there yet. We use version 3.x of the Media Revisions UI because we need some custom work on top of it and we do not want to do that on 2.x and have to do it over again when 3.x is officially released.

Composer refuses to install the 3.x-dev version even if we fix the commit to the previous one:

Problem 1
    - drupal/media_revisions_ui dev-3.x requires drupal/core ^10.1 -> found drupal/core[10.1.x-dev] but the package is fixed to 9.5.3 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - drupal/media_revisions_ui 3.x-dev is an alias of drupal/media_revisions_ui dev-3.x and thus requires it to be installed too.
    - Root composer.json requires drupal/media_revisions_ui 3.x-dev#cd14c77b0d41e20f9015c4a9e985d53037d7f20e -> satisfiable by drupal/media_revisions_ui[3.x-dev (alias of dev-3.x)].

Any suggestions to work around this would be appreciated!

@ricovandevin I recommend using this plugin which allows you to relax core version constraints on certain modules

You can then patch the module with a local patch to allow D10.

Automatically closed - issue fixed for 2 weeks with no activity.