- Issue created by @tedbow
- Assigned to phenaproxima
- 🇺🇸United States phenaproxima Massachusetts
Opened ✨ [PP-1] Add support for scaffold files that aren't defined by Drupal core or the root composer.json Postponed as a follow-up here.
- Issue was unassigned.
- 🇺🇸United States phenaproxima Massachusetts
Given that the scope of this issue, per discussion with @tedbow, only involves the file mapping from drupal/core and the root composer.json, I think it's probably okay if someone who isn't me deals with this.
- Assigned to kunal.sachdev
- @kunalsachdev opened merge request.
- @kunalsachdev opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 11:04am 15 February 2023 - Status changed to Needs work
almost 2 years ago 1:46pm 15 February 2023 - Status changed to Needs review
almost 2 years ago 2:16pm 15 February 2023 - Assigned to kunal.sachdev
- Status changed to Needs work
almost 2 years ago 10:24am 16 February 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Did you try running it locally? The creator of the fixture itself does not have tests, so a green test run is meaningless!
$ composer create-site-fixture ~/core > \Drupal\automatic_updates\Development\ComposerFixtureCreator::createFixture Script \Drupal\automatic_updates\Development\ComposerFixtureCreator::createFixture handling the create-site-fixture event terminated with an exception In ComposerFixtureCreator.php line 39: file_get_contents(/Users/wim.leers/core/modules/contrib/automatic_updates/scripts/src/../../package_manager/tests/fixtures/fake_site../path_repos/drupal--core/composer.json) : Failed to open stream: No such file or directory create-site-fixture [--dev] [--no-dev] [--] [<args>...]
And if I fix that I get
$ composer create-site-fixture ~/core > \Drupal\automatic_updates\Development\ComposerFixtureCreator::createFixture Script \Drupal\automatic_updates\Development\ComposerFixtureCreator::createFixture handling the create-site-fixture event terminated with an exception In ComposerFixtureCreator.php line 41: Undefined array key "drupal-scaffold" create-site-fixture [--dev] [--no-dev] [--] [<args>...]
- 🇮🇳India kunal.sachdev
If I run it locally I get
$ composer create-site-fixture ../../../core > \Drupal\automatic_updates\Development\ComposerFixtureCreator::createFixture Script \Drupal\automatic_updates\Development\ComposerFixtureCreator::createFixture handling the create-site-fixture event terminated with an exception In ComposerFixtureCreator.php line 39: file_get_contents(/Users/kunal.sachdev/www/d9-autoupdates/modules/contrib/a utomatic_updates/scripts/src/../../package_manager/tests/fixtures/fake_site ../path_repos/drupal--core/composer.json): Failed to open stream: No such f ile or directory create-site-fixture [--dev] [--no-dev] [--] [<args>...]
And if I fix that I get
$ composer create-site-fixture ../../../core > \Drupal\automatic_updates\Development\ComposerFixtureCreator::createFixture Fixture created 🎉.%
- Assigned to wim leers
- Status changed to Needs review
almost 2 years ago 11:04am 16 February 2023 - Assigned to kunal.sachdev
- Status changed to Needs work
almost 2 years ago 3:57pm 16 February 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
composer create-site-fixture ~/core
was wrong of me!
I should've done
$ composer create-site-fixture ~/core/core > \Drupal\automatic_updates\Development\ComposerFixtureCreator::createFixture Fixture created 🎉.
I can confirm this works correctly. But what's missing is actually including the results of executing that command in this MR! 😅
- Assigned to wim leers
- Status changed to Needs review
almost 2 years ago 1:05pm 17 February 2023 - Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 7:35am 20 February 2023 - Assigned to kunal.sachdev
- Status changed to Needs work
almost 2 years ago 7:35am 23 February 2023 - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:08am 23 February 2023 - Status changed to RTBC
almost 2 years ago 10:14am 23 February 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
- Changes look good. 👍
- Manual test:
curl https://git.drupalcode.org/project/automatic_updates/-/merge_requests/701.diff | git apply -3v
$ rm -rf package_manager/tests/fixtures/fake_site/composer.lock wim.leers at MacBookPro-WimLeers in ~/core/modules/contrib/automatic_updates on 3.0.x* $ composer create-site-fixture /Users/wim.leers/core/core > \Drupal\automatic_updates\Development\ComposerFixtureCreator::createFixture Fixture created 🎉. wim.leers at MacBookPro-WimLeers in ~/core/modules/contrib/automatic_updates on 3.0.x* $ git diff wim.leers at MacBookPro-WimLeers in ~/core/modules/contrib/automatic_updates on 3.0.x*
⇒ 🚀
-
phenaproxima →
committed cdcdf2da on 3.0.x authored by
kunal.sachdev →
Issue #3339714 by kunal.sachdev, Wim Leers: Dynamically copy scaffold...
-
phenaproxima →
committed cdcdf2da on 3.0.x authored by
kunal.sachdev →
- Status changed to Fixed
almost 2 years ago 1:26pm 23 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.