Always show summary of validation result if exists

@phenaproxima did you check the other place mentioned in Proposed resolution 2)?

Looks good but I don't the original problem documented in the screenshot has test coverage.

This is when the User is on the UpdateReady form and there is a status check warning with 1 message and summary.

the closest test coverage we have is \Drupal\Tests\automatic_updates\Functional\UpdateWarningTest but it only deals with an warning with more than 1 message, that is why it was passing.

That should be update to handle both cases. I think just setting a different `TestSubscriber::setTestResult([$warning], StatusCheckEvent::class);` and reloading the page should be ok

Crediting you for review.

🤯 This is such a no-brainer improvement. This explains why I've gotten confused in the past by the assertions in the build tests 😄

But … there's still something that I don't quite get: why we sometimes want only the summary, and not also the non-summarized messages?

why we sometimes want only the summary, and not also the non-summarized messages?

As I understand it:

On the status report, and on the updater form, we want everything. Summaries and details. These areas are where the user is most concerned with the details, and could use as much information as possible to fix the problems.

On any other admin page, we want only the summaries (or first message, if there is no summary). In such a context, we just want people to know that problems exist, and give people a basic idea of what those problems are. But providing the full details would be clutter.

Not seeing any other actionable feedback here, so this is back to needing review...

On any other admin page (like /admin/structure and friends), we want only the summaries (or first message, if there is no summary). In such a context, we just want people to know that problems exist, and give people a basic idea of what those problems are. But providing the full details would be clutter.

But how do we expect people to act on problems surfaced in the status report if they literally cannot see the details? 😅

They can see the details on the status report...? (By "status report", by the way, I'm referring specifically to /admin/reports/status.)

That's not what I'm seeing in StatusCheckTest — see https://git.drupalcode.org/project/automatic_updates/-/merge_requests/68....

I verified locally by doing

var_dump($expected_results['1 error']);
var_dump($this->getSession()->getPage()->getContent());
return;

immediately after that.

What am I missing? 🙈

The fact that the result you're looking at only has one message. In which case, that's the only thing that gets displayed.

If I add the following code to the end of ComposerExecutableValidator:

    $event->addError([
      'One message with some details.',
      'Another message with some details.',
    ], t('A test summary'));

I get this on the status report:

Which is exactly what I would expect to see.

OMG — I must've missed that then in my detailed test 🙈 Sorry for the distraction!

Automatically closed - issue fixed for 2 weeks with no activity.