- Issue created by @msn5158
- Assigned to bobi-mel
- Open on Drupal.org โCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - @bobi-mel opened merge request.
- last update
about 1 year ago 2 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 1:36pm 2 October 2023 - ๐บ๐ฆUkraine bobi-mel
The possibility of adding a description to setting was added by me. Please check it.
- ๐ฎ๐ณIndia SandeepSingh199
Hi @bobi-mel, I review your patch in my local & found two issue.
1. Create Setting button will display in description column.
2. while adding data in description column (Description of the Site Settings.) , it's not saving.Steps to Replicate : -
For Issue 1 :
1. Structure > Manage site Setting
2. Click on Add Site Setting Type button, fill some data and Save
3. Add any one field in Manage fields
4. Move to Content > Site Setting
5. here you can see the issue 1.For Issue 2:
6. On the same page click on Create Setting button.
7. Add data on Description filed & Save
8. after save page will redirect to admin/content/site-settings
9. here you can see the issue 2.If you want i can fix this issue, please let me know.
- Status changed to Needs work
about 1 year ago 9:13am 3 October 2023 - Assigned to bobi-mel
- last update
about 1 year ago 2 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 2:29pm 4 October 2023 - ๐บ๐ฆUkraine bobi-mel
Hi @SandeepSingh199 thanks for the feedback.
As for the first issue it really my mistake and I fixed it.
as for the second issue, I think you have already been using this module and have the saved settings in the DB. After applying the patch you need to run drush updb command to update the schema of DB because it doesn't have a field for saving the Description value.
Can you try to apply new my changes, double-check them, and add new feedback? - ๐ฎ๐ณIndia SandeepSingh199
Thanks @bobi-mel, Issue 1 is fixed now & Issue 2 is my fault, i havenโt run that drush updb command, now i run that & found Description filed data is Saving now. All looks good to me, we can move this to RTBC+1.
- First commit to issue fork.
- last update
about 1 year ago 2 pass - last update
about 1 year ago 2 pass - ๐ฌ๐งUnited Kingdom scott_euser
Thanks! I did the following, can you check you are still happy with it?
- Moved update hook to install file
- Updated field description to explain more about its usage
- Minor coding standards
- ๐บ๐ฆUkraine bobi-mel
@scott_euser
As for me, it looks better. Thanks for the review and improves - last update
about 1 year ago 2 pass -
scott_euser โ
committed ae7dea34 on 8.x-1.x authored by
bobi-mel โ
Issue #3339113 by bobi-mel, scott_euser, SandeepSingh199: Add...
-
scott_euser โ
committed ae7dea34 on 8.x-1.x authored by
bobi-mel โ
- Status changed to Fixed
about 1 year ago 4:27am 24 October 2023 - ๐ฌ๐งUnited Kingdom scott_euser
And thanks particularly to bobi-mel for doing the hard work on this one
Automatically closed - issue fixed for 2 weeks with no activity.