Drupal Coding Standards Issues | phpcs

Created on 31 January 2023, over 1 year ago

Problem/Motivation

FILE: .../sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/form_display_visibility/tests/src/Kernel/FormDisplayVisibilityAccessByPermissionTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------
25 | WARNING | [x] '@TODO Publish the schema so this is not needed.' should match the format '@todo Fix problem X here.'
79 | ERROR | [ ] Missing member variable doc comment
80 | ERROR | [ ] Missing member variable doc comment
-----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/form_display_visibility/README.md
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
2 | WARNING | Line exceeds 80 characters; contains 178 characters
----------------------------------------------------------------------------------------------------------

Steps to reproduce

Run the following command: phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml /10.1.x/drupal/modules/contrib/form_display_visibility

Proposed resolution

Resolve all the php coding standard issues/warnings

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Closed: won't fix

Version

2.0

Component

Code

Created by

🇮🇳India sahil.goyal

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @sahil.goyal
Status changed to Needs review over 1 year ago8:38am 31 January 2023
Comment over 1 year ago →
🇮🇳India sahil.goyal
Fix the phpcs warnings/erros. please review
Comment over 1 year ago →
🇮🇳India Charchil Khandelwal
Charchil Khandelwal → made their first commit to this issue’s fork.
Assigned to Charchil Khandelwal
Comment over 1 year ago →
🇮🇳India Charchil Khandelwal
I will review this.
@charchil-khandelwal opened merge request.
Issue was unassigned.
Comment over 1 year ago →
🇮🇳India Charchil Khandelwal
patch #2 applied clearly, all the errors and warnings are fixed.
Also i created MR !1 for this issue, please review.

Thank You.
Status changed to Closed: won't fix over 1 year ago10:01am 31 January 2023
Comment over 1 year ago →
🇪🇸Spain pcambra Spain, 🇪🇺
We're not doing this, stop gaming the system.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024