Drupal Coding Standards Issues | phpcs

Open on Drupal.org →

Created on 31 January 2023, about 2 years ago

Updated 15 March 2023, almost 2 years ago

Problem/Motivation

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/slimbox2/slimbox2.module
------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 3 WARNINGS AFFECTING 9 LINES
------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
4 | ERROR | [x] There must be one blank line after the last USE statement; 0 found;
7 | ERROR | [x] Doc comment short description must end with a full stop
10 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
11 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
14 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
17 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
34 | ERROR | [x] Case breaking statement indented incorrectly; expected 6 spaces, found 4
39 | ERROR | [x] Short array syntax must be used to define arrays
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/slimbox2/slimbox2.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Closed: outdated

Version

1.3

Component

Code

Created by

🇮🇳India sahil.goyal

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @sahil.goyal
Comment about 2 years ago →
🇮🇳India sahil.goyal
Fixing all the PHP Coding standard issues.
Comment about 2 years ago →
🇮🇳India Charchil Khandelwal
Charchil Khandelwal → made their first commit to this issue’s fork.
@charchil-khandelwal opened merge request.
Status changed to Needs review about 2 years ago5:02am 31 January 2023
Comment about 2 years ago →
🇮🇳India Charchil Khandelwal
Created MR for this issue, Please review.

Thank You.
Status changed to RTBC about 2 years ago10:36am 31 January 2023
Comment about 2 years ago →
gaurav-mathur
Thanks @sahil.goyal and @Charchil Khandelwal, its looks good now.
So, moving to RTBC.

Thank You.
Status changed to Closed: outdated almost 2 years ago7:47pm 15 March 2023
Comment almost 2 years ago →
🇨🇦Canada awasson
Hi there,

Thanks for your interest in helping with the Slimbox2 module. I'm closing this as outdated as I have overhauled the code extensively and the issues in the report are no longer relevant.

Cheers,
Andrew

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024