If user doesn't have access to scheduled state, they are unable to edit the scheduled content

Can look at it more later this week. But essentially when you do a schedule you are saying this revision needs to be published. If you let a user then edit it and create a new revision then the schedule would need to be cancelled out. Not sure if that’s people’s desired behavior though.

For #2

Under the current described workflow it would seem once an approver sets the scheduler if an editor can go in and edit then they can get around the reviewer and publish what they want.

Under the current described workflow it would seem once an approver sets the scheduler if an editor can go in and edit then they can get around the reviewer and publish what they want.

That would only happen if the editor has permission to perform a workflow transition that would publish it. In my scenario, the permissions on workflow transitions don't allow a non-admin (editor) to perform any transition into a published state.

Here's the list of my workflow states:

1. Draft
2. Needs Review
3. Scheduled
4. Published
5. Archived

Non-admins (editors) have permission to perform the following transitions:

1. Save Draft (Draft, Needs Review -> Draft)
2. Submit for review (Draft, Needs Review, Scheduled, Published, Archived -> Needs Review)

Admins (approvers) can do the above but also:

1. Schedule (Needs Review -> Scheduled)
2. Publish (Draft, Needs Review, Archive -> Published)
3. Archive (Published -> Archive)

However, because scheduler_content_moderation_integration_entity_access() limits the transitions to the ones stored at $entity->publish_state and $entity->unpublish_state, non-admins (editors) cannot perform either of their transitions.

So again I ask, why does this module tinker with workflow transition permissions? If the transition permissions are incorrectly configured, that's not this module's fault. IMHO, this module should only worry about scheduling one transition to another, not changing how the core transition permissions work. Unless it has a certain reason to do so, and then only if the opted into.

We have just recently run into this in setting up the module for our sites. We have a similar role that can create, edit but not schedule/publish who are locked out from making edits until the scheduled date is processed.

We are adding messages alerting the users that this is the case so they don't get confused why they can edit other nodes of this type but not these.