Move migration tests to the Forum module

Fix the failing test, it was just an entity count in \Drupal\Tests\migrate_drupal_ui\Functional\d6\Upgrade6Test

Now, do two things
1) Reduce the size of the test fixtures.
2) Change the forum Kernel tests to use the fixture in the forum module, not migrate_drupal.

+++ b/core/modules/forum/tests/src/Functional/migrate_drupal/d6/Upgrade6Test.php
@@ -48,44 +48,40 @@ protected function getSourceBasePath() {
-      'block' => 36,
-      'block_content' => 2,
+      'block' => 32,
+      'block_content' => 1,
       'block_content_type' => 1,
-      'comment' => 6,
-      // The 'standard' profile provides the 'comment' comment type, and the
-      // migration creates 12 comment types, one per node type.
-      'comment_type' => 14,
-      'contact_form' => 5,
+      'comment' => 4,
+      'comment_type' => 8,
+      'contact_form' => 2,
       'contact_message' => 0,

Is there anyway we can make this more robust, the equivalent test in Aggregator fails everytime something in core changes

This looks good to me, but I'm no expert in Migration tests

The changes to the entity counts are because I made new source fixtures for Forum. I did that by starting with the existing fixtures and then used the UI to remove non Forum related entities and config. For example, all the translations were removed and many, many fields. The fixtures are now more appropriate for testing Forum migration via the UI. They fixtures should now be easier to work with in the future. And as a bonus, the patch is 2MB smaller.

The test will still, unfortunately, be effected by changes to the core standard profile. That is a side effect of testing the entity counts.

Ok thanks for that

This looks good to me

Committed a32ff78 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.