Contrib.social

Improve FieldItemBase class

Open on Drupal.org →
Created on 25 January 2023, over 2 years ago

Problem/Motivation

`FieldItemBase::getEntity()` and `getLangcode()` both use the return of `getParent()` without checking whether it is Null.

`FieldItemBase` functions use `$this->definitions` while there is a perfectly good `getDataDefinition()` call which returns it and IMO should be used.

FieldItemBase could benefit from having 'replica' copies of `getPropertyDefinition($n)` and `getPropertyDefinitions()` calling through `getDataDefinition()`.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

10.1 ✨

Component
Field  →

Last updated 21 days ago

Created by

🇬🇧United Kingdom rivimey

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024