- Issue created by @nginex
- Assigned to abramm
- Status changed to Needs work
almost 2 years ago 3:53pm 28 January 2023 - 🇺🇦Ukraine abramm Lutsk
I've basically done with moving hardcoded fields exporting/importing processes to plugins.
Remaining tasks:
- Update README.
- Add field import/export events to allow other modules reacting on import/export and alter fields values (old hooks are now deprecated since they were misused for adding custom field types support).
- Update hooks API documentation, document their deprecation.
- Testing; I verified automated tests and tested a few things manually but I'm not 100% sure everything is in place.
- @abramm opened merge request.
- 🇺🇦Ukraine abramm Lutsk
Oh and also exporting base fields (\Drupal\single_content_sync\ContentExporter::exportBaseValues) should be moved to plugins as well; but I guess this should be a followup issue.
- Assigned to igor mashevskyi
- 🇺🇦Ukraine nginex
There are some new bug fixings and improvements in 1.3.x.
Rebase against 1.3.x is a must
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:15am 30 March 2023 - Assigned to abramm
- Status changed to Active
over 1 year ago 12:06pm 30 May 2023 - 🇺🇦Ukraine nginex
Hi @abramm,
Based on drupal 9 experience, I think we can deprecate hooks in future minor release e.g. 1.5.x. In this case, any deprecated functionality will be completely removed from 2.0.x, so we will not need to release one more major version after 2.x that does not contain hooks.
If you agree I will create one more issue and new minor tag 1.5.x, (1.4.x is still on my agenda to release soon)
- 🇺🇦Ukraine abramm Lutsk
Hey @nginex,
You're the boss :).
There's still some work to be done in this MR first though. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:07pm 21 June 2023 - 🇺🇦Ukraine abramm Lutsk
Hey @nginex, mind having another look?
The MR is currently based off 1.3.x and is feature complete (including the README). - 🇺🇦Ukraine nginex
Hi @abramm, thank you for this hard work, I will review it by the end of the week, If needed I will make some adjustments and move it to the new minor version. I will keep you posted
- Status changed to Needs work
over 1 year ago 5:28am 26 June 2023 - 🇺🇦Ukraine nginex
1. Fix conflicts
2. Apply latest changes from 1.4.x (if any)
3. Fix open issues from the MR
4. Functional testing will be done once the above things are fixed. - Status changed to Needs review
over 1 year ago 9:14am 5 July 2023 - 🇺🇦Ukraine abramm Lutsk
Hi @nginex,
That wasn't easy as I had to rebuild the whole branch again :).
All the issues are now resolved; I've also reviewed upstream changes to fields import/export code and updated corresponding plugins accordingly.
I'm a big fan of keeping clean Git history so I did rebase and added all edits to corresponding commits. I believe the right way to merge this is to not use squash as commits history could be important for anyone doing further work.
Please let me know if there's something else needed before this could be merged.
- 53d21536 committed on 1.4.x
Issue #3336402: Update README.md
- 53d21536 committed on 1.4.x
- f11ef0e6 committed on 1.4.x
Issue #3336402: Deprecate hook_content_export_entity_alter in favor of...
- f11ef0e6 committed on 1.4.x
- a27dbe18 committed on 1.4.x
Issue #3336402: Deprecate hook_content_import_entity_alter in favor of...
- a27dbe18 committed on 1.4.x
- d4b494f4 committed on 1.4.x
Issue #3336402: Deprecate hook_content_export_field_value_alter and...
- d4b494f4 committed on 1.4.x
- 038720a3 committed on 1.4.x
Issue #3336402: Add node, media, block_content, paragraph, taxonomy_term...
- 038720a3 committed on 1.4.x
- 2227d497 committed on 1.4.x
Issue #3336402: Add Base Fields Processor plugin type...
- 2227d497 committed on 1.4.x
- f415e86f committed on 1.4.x
Issue #3336402: Add files / images fields processor plugin
- f415e86f committed on 1.4.x
- d1b7813e committed on 1.4.x
Issue #3336402: Add layout section field processor plugin
- d1b7813e committed on 1.4.x
- b070177b committed on 1.4.x
Issue #3336402: Add webform field processor plugin
- b070177b committed on 1.4.x
- a4807782 committed on 1.4.x
Issue #3336402: Add metatag field processor plugin
- a4807782 committed on 1.4.x
- b9dc3c84 committed on 1.4.x
Issue #3336402: Add entity reference processors plugins
- b9dc3c84 committed on 1.4.x
- 744b4f01 committed on 1.4.x
Issue #3336402: Add text field processor plugin
- 744b4f01 committed on 1.4.x
- f1cb6886 committed on 1.4.x
Issue #3336402: Add simple field processor plugin
- f1cb6886 committed on 1.4.x
- 855234f6 committed on 1.4.x
Issue #3336402: Remove field import/export switch/case operators, call...
- 855234f6 committed on 1.4.x
- e235997a committed on 1.4.x
Issue #3336402: Inject field processor plugin manager to importer and...
- e235997a committed on 1.4.x
- e322a7a6 committed on 1.4.x
Issue #3336402: Add Field Processor plugin type & plugin manager
- e322a7a6 committed on 1.4.x
- Status changed to Fixed
over 1 year ago 1:38pm 8 July 2023 - 🇺🇦Ukraine nginex
It's finally happening.
Big thanks to @abramm and @Igor Mashevskyi
I'm going to create 1.4.0-beta1 release and create a few issues to handle these todos before we create a final stable 1.4.0 release:
- Update README.
- Add field import/export events to allow other modules reacting on import/export and alter fields values (old hooks are now deprecated since they were misused for adding custom field types support).
- Update hooks API documentation, document their deprecation (how to migrate guide in the documentation). - 🇺🇦Ukraine nginex
For now all future fixes and changes in 1.3.x should be also migrated to 1.4.x before we create first stable 1.4.0 release
- 🇺🇦Ukraine nginex
Created beta1 release. See https://www.drupal.org/project/single_content_sync/releases/1.4.0-beta1 →
Updated homepage of the module. See https://www.drupal.org/project/single_content_sync → Automatically closed - issue fixed for 2 weeks with no activity.