core_version_requirement not recognized before 8.7.7

Created MR for the issue.
Please review.
Thanks

RTBC! You're right!

Sorry, but this is just contrib credit harvesting. Without the core property, the module won't work in Drupal 8.7 anyway. Anyone dumb enough to still be running Drupal 8.7, and not Drupal 8.9 kind of deserves that their site gets broken. If this module is forcing them to do the right thing and at least upgrade to 8.9, that's a pretty useful side-effect.

jcnventura → closed merge request !7

@jcnventura: I sometimes also get angry because of the credit harvesting, but you can't say I'm doing such things.

Still it's best practice to use ^8.8 or (I fully agree with your Drupal 8 EOL user hate): ^8.9 which is totally fine.

See https://www.drupal.org/node/3070687 →

So simply don't credit anyone, but simply please change ^8 to ^8.9 to use best practice.

Still you're the maintainer and decide, but I wanted to let you know about that change record and we should be clean and stick to standards, where we can be. So in fact this was wrongly introduced when removing the core: 8.x attribute.

The problem is that this is now a problem that can no longer be fixed. The release 8.x-1.3 will forever be able to be installed in any version of Drupal 8, but it won't run as it doesn't have the core property. Adding an ^8.8 or ^8.9 at this point will simply prevent old sites from getting new versions, but it doesn't unbreak them if 8.x-1.3 is installed by running `composer update`.

AFAIK there's no way to change the drupal.org packagist to now restrict that version to ^8.7.7 or ^8.8. If there is, then I'm open to re-open this. But without that, this is pretty meaningless. I'll try in the future to make sure that I add ^8.7.7 to any other module when removing the core property, but doing it for modules with tagged D10 releases already is not going to change anything to all those 36K sites still running Drupal <8.8.