t() calls should be avoided in classes

Patch created. Please review it

I will review this.

Thanks

FILE: /var/www/html/dcontri/charts_twig/src/ChartsTwig.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank line
 29 | ERROR   | [x] You must use "/**" style comments for a function comment
 35 | WARNING | [ ] Only string literals should be passed to t() where possible
 42 | WARNING | [ ] Only string literals should be passed to t() where possible
 48 | WARNING | [ ] Only string literals should be passed to t() where possible
 53 | WARNING | [ ] Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------

After applying the above patch. I found the string literal issues along with the formatting issues and fixed them.
Please check.

Thanks

I see the patch is applying and all the issues are fixed. Marking as RTBC.

Thank you all for your patches. The base class does not have the string translation method, so it was necessary to add the StringTranslationTrait in order to use $this->t(). I also added a couple adjustments to the docblock, parameters while I was in the code.

OK, so right after I created the last patch, I did some testing and realized the $this->t() was not getting reached. If you want to translate, you need to use |t or |trans in the Twig code itself. I added documentation in the README. I also replaced $this->t() with Xss::filter() to provide additional controls on the strings that users can input.

Automatically closed - issue fixed for 2 weeks with no activity.