- Issue created by @omkar.podey
- @omkarpodey opened merge request.
- 🇮🇳India omkar.podey
Added an unnecessary doc block will remove it once the tests pass.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
This blocks 🐛 GitExcluder should not ignore .git directories that belong to packages installed by Composer Fixed , so matching priority.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Requested one small piece of extra test coverage 🤓
- Assigned to Wim Leers
- Status changed to Needs review
over 1 year ago 3:11am 24 January 2023 - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 8:51am 24 January 2023 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Beautifully clear and elegant merge request, with very clear test coverage too — and indeed good call to use
FixtureManipulatorinstead of(Active|Stage)FixtureManipulator— both of those are just very thin wrappers aroundFixtureManipulatorthat merely add guarantees that they were indeed applied to active/stage dir respectively 👍Let's get this in!
- First commit to issue fork.
- 🇮🇳India omkar.podey
I found a bug while making it work with 🐛 GitExcluder should not ignore .git directories that belong to packages installed by Composer Fixed push fix + test extension
- Status changed to Needs work
over 1 year ago 1:26pm 24 January 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
@omkar.podey 1 more test change needed
- Assigned to tedbow
- Status changed to Needs review
over 1 year ago 2:11pm 24 January 2023 - Status changed to RTBC
over 1 year ago 3:58pm 24 January 2023 -
tedbow →
committed 4e5e5b13 on 8.x-2.x authored by
omkar.podey →
Issue #3335802 by omkar.podey, tedbow: Add addDotGitFolder functionality...
-
tedbow →
committed 4e5e5b13 on 8.x-2.x authored by
omkar.podey →
- Status changed to Fixed
over 1 year ago 4:43pm 24 January 2023 Automatically closed - issue fixed for 2 weeks with no activity.
