- Assigned to omkar.podey
- Status changed to Needs work
almost 2 years ago 3:02pm 16 January 2023 - Status changed to Postponed
almost 2 years ago 8:21am 17 January 2023 - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 11:10am 17 January 2023 - Status changed to RTBC
almost 2 years ago 12:10pm 17 January 2023 - Status changed to Needs work
almost 2 years ago 4:31am 18 January 2023 - Assigned to omkar.podey
- Assigned to wim leers
- Status changed to Needs review
almost 2 years ago 10:34am 18 January 2023 - Assigned to omkar.podey
- Status changed to Needs work
almost 2 years ago 1:33pm 18 January 2023 - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:25am 20 January 2023 - Assigned to omkar.podey
- Status changed to Needs work
almost 2 years ago 10:29am 20 January 2023 - Assigned to tedbow
- Status changed to RTBC
almost 2 years ago 11:02am 23 January 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Manually did
phpcs
locally, all green 👍The follow-up I requested in #56 was created: 📌 Add new InstalledPackagesList which does not rely on Composer API to get package info Fixed .
- Assigned to wim leers
- Status changed to Needs work
almost 2 years ago 12:34pm 23 January 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
Needs work
See question I put on the MR about the need for the new fixture
We just put a lot of effort into getting rid of most fixture folders so I want make sure we need this one.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I like it! 😄
Postponing on 📌 Add addDotGitFolder functionality to \Drupal\fixture_manipulator\FixtureManipulator Fixed .
- Issue was unassigned.
- Status changed to Postponed
almost 2 years ago 1:44pm 23 January 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This blocks 📌 Ensure that intentionally failed test stage directories are deleted after tests complete Fixed , so tagging.
- 🇮🇳India omkar.podey
If the test above passes it proves the compatibility with 📌 Add addDotGitFolder functionality to \Drupal\fixture_manipulator\FixtureManipulator Fixed
- Status changed to Active
almost 2 years ago 4:45pm 24 January 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
- Assigned to wim leers
- Status changed to Needs work
almost 2 years ago 1:30pm 25 January 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I'll get this across the finish line while @omkar.podey is on PTO.
First,
git merge origin/8.x-2.x
… - Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 1:56pm 25 January 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Since #71:
- removed the fixture that was possible to remove thanks to 📌 Add addDotGitFolder functionality to \Drupal\fixture_manipulator\FixtureManipulator Fixed
- and then reviewed + minimized the diff:
- fixed an incorrectly resolved merge conflict (by deleting code 😁)
- reverted the
LockFileValidator
::stopPropagation()
additions which seem to be obsolete now. - reverted the
StagedDBUpdateValidatorTest
change because that seems to be obsolete too now
That took this MR down from 13 changed files to a mere 3!
-
tedbow →
committed 2b5ef569 on 8.x-2.x authored by
kunal.sachdev →
Issue #3315834 by omkar.podey, kunal.sachdev, tedbow, Wim Leers,...
-
tedbow →
committed 2b5ef569 on 8.x-2.x authored by
kunal.sachdev →
- Status changed to Fixed
almost 2 years ago 4:14pm 26 January 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
Thanks everyone! A lot of work but a big win we don't message with git folder managed by Composer!
Automatically closed - issue fixed for 2 weeks with no activity.