Contrib.social

Drupal Coding Standards Issues | phpcs

Open on Drupal.org →
Created on 17 January 2023, over 1 year ago
Updated 23 May 2023, about 1 year ago

Problem/Motivation

Getting following error/warnings

FILE: /var/www/html/modules/contrib/formassembly/tests/src/Unit/FormassemblyHtmlResponseAttachmentsProcessorTest.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
20 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/formassembly.module
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
7 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
-------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Form/FormAssemblyEntityDeleteForm.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
10 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Form/FormAssemblyEntityForm.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------
18 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
135 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Form/FormAssemblyEntitySettingsForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 17 WARNINGS AFFECTING 20 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
163 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
164 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
165 | ERROR | [x] Use null coalesce operator instead of ternary operator.
171 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
172 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
173 | ERROR | [x] Use null coalesce operator instead of ternary operator.
181 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
183 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
190 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
191 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
197 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
198 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
201 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
212 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
213 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
219 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
239 | WARNING | [ ] #options values usually have to run through t() for translation
240 | WARNING | [ ] #options values usually have to run through t() for translation
260 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/FormAssemblyEntityListBuilder.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------
13 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
40 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/ApiMarkup.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
19 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/ApiAuthorize.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Entity/FormAssemblyEntityInterface.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
11 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Entity/FormAssemblyEntityViewsData.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
10 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Entity/FormAssemblyEntityViewBuilder.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
15 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
76 | ERROR | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('tfa_next')
| | instead
80 | ERROR | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('tfa_next')
| | instead
82 | ERROR | [x] list(...) is forbidden, use [...] instead.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Entity/FormAssemblyEntity.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/FormAssemblyEntityAccessControlHandler.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
13 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Plugin/KeyType/FormAssemblyOauth.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
10 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Component/Render/FormBodyUnescapedMarkup.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
12 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Component/Render/FormassemblyHtmlResponseAttachmentsProcessor.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
23 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Controller/OauthInteractions.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
15 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Commands/FormassemblyCommands.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
11 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/FormAssemblyBatchProcessor.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
15 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/FormAssemblyStorage.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
10 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/Exception/FormAssemblyException.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
8 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
-------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/ApiBase.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
105 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/FormAssemblyEntityHtmlRouteProvider.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
12 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/formassembly/src/ApiSync.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
17 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------------------------------------------------------

Time: 2.98 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/formassembly/

Proposed resolution

Above error/warnings need to be fixed.

🐛 Bug report
Status

Closed: cannot reproduce

Version

2.0

Component

Code

Created by

🇮🇳India samit.310@gmail.com

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Assigned to Sonal Gyanani
  • Issue was unassigned.
  • Status changed to Needs work over 1 year ago
  • Status changed to Needs review over 1 year ago
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States FatherShawn New York

    Please see #6. DrupalPractice is not a coding standard.

  • Status changed to Closed: cannot reproduce about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States FatherShawn New York
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024