Contrib.social

PHP 8.2 compatibility fix

Open on Drupal.org →
Created on 17 January 2023, almost 2 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

webform_localization shows that webform is failing PHP 8.2 dynamic properties for $export_wordwrap on the webform_exporter class in includes/exporters/webform_exporter.inc

W✓		-createWebformTranslation
✓		-createStringTranslation
✗	
__construct
exception: [Deprecated function] Line 18 of sites/all/modules/webform/includes/exporters/webform_exporter.inc:
Creation of dynamic property webform_exporter_delimited::$export_wordwrap is deprecated

exception: [Deprecated function] Line 18 of sites/all/modules/webform/includes/exporters/webform_exporter.inc:
Creation of dynamic property webform_exporter_delimited::$export_wordwrap is deprecated

....
several times

https://www.drupal.org/pift-ci-job/2569479 →

Steps to reproduce

See patch

Proposed resolution

See patch

Remaining tasks

See patch

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Fixed

Version

4.0

Component

Code

Created by

🇨🇦Canada joseph.olstad

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to RTBC almost 2 years ago
  • Issue was unassigned.
  • Status changed to Closed: works as designed almost 2 years ago
  • Status changed to Needs review almost 2 years ago
  • Status changed to Fixed almost 2 years ago
  • Comment almost 2 years ago →
    🇨🇦Canada joseph.olstad

    @Liam Morland, just wondering, when is 4.25 going to be tagged and released?

    Is the delay on webform 7.x-4.25 going to be two weeks?

    It's been one week already.

    Next saturday it will be two weeks since 7.x-4.25-rc2

  • Comment almost 2 years ago →
    🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    I usually make a full release once the RC is two weeks old with no release-blockers.

  • Comment almost 2 years ago →
    🇨🇦Canada joseph.olstad

    Looking forward to the release, as maintainer of webfirm_localization , I want the tagged release to get the fixes that resolve the automated test results fixed that are still failing due to the spelling error of export_wordwrap

    The automated tests use the previous tagged release that has the bug.

  • Comment almost 2 years ago →
    🇨🇦Canada joseph.olstad

    There's also two other automated test fails that are failing due to what appears to be changes between webform releases since 2018
    when I triggered tests for PHP 8.2 compatibility fixes, it was the first time webform_localization tests had been run since 21 Mar 2019 at 12:26 EDT when they last succeeded 100%

    no code changes were made in webform_localization however two tests failed.

  • Comment almost 2 years ago →
    🇨🇦Canada joseph.olstad

    @Liam Morland, it's been more than two weeks now, can you please push a full release tag including this PHP 8.2 fix?

  • Comment almost 2 years ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024