- Status changed to Postponed: needs info
about 2 years ago 7:19pm 17 January 2023 - Status changed to Needs review
about 2 years ago 4:09pm 18 January 2023 - 🇺🇸United States agentrickard Georgia (US)
This needs re-evaluation after 🐛 Code style and phpstan fixes. Fixed went in.
- 🇩🇪Germany Anybody Porta Westfalica
Thank you, I think we should ensure the required minimum PHP and Drupal version in the module info.yml file. Could someone provide a MR with the required changes please?
- 🇺🇸United States agentrickard Georgia (US)
@anybody
I don't think that is necessary. This isn't a PHP version issue. This patch corrects for over-zealous PHPStan rules (specifically level 9):
https://phpstan.org/user-guide/rule-levels
be strict about the mixed type - the only allowed operation you can do with it is to pass it to another mixed
Drupal core simply doesn't allow support for this rule.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks! @agentrickard could you please turn this into a MR?
- Status changed to Needs work
6 months ago 8:46am 4 September 2024