\Drupal\comment\CommentForm::save does not return a value

Created on 16 January 2023, almost 2 years ago
Updated 12 July 2024, 5 months ago

According to EntityFormInterface this method should return integer value indicating the result of the operation.

Unlike 🐛 function Drupal\Node\NodeForm::save() does not return a value Needs work this issue is a bit more complicated because in some conditions \Drupal\comment\CommentForm::save may not perform any operations. So that it's not clear what it should return.
Basically we have two options here.
1. Introduce new "SAVED" constant. Something like SAVED_SKIPPED
2. Refactor CommentForm to not check permissions in submit handler.

🐛 Bug report
Status

Active

Version

11.0 🔥

Component
Comment 

Last updated 8 days ago

Created by

🇷🇺Russia Chi

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
Production build 0.71.5 2024