\Drupal\comment\CommentForm::save does not return a value

Created on 16 January 2023, over 1 year ago

According to EntityFormInterface this method should return integer value indicating the result of the operation.

Unlike πŸ› function Drupal\Node\NodeForm::save() does not return a value Needs work this issue is a bit more complicated because in some conditions \Drupal\comment\CommentForm::save may not perform any operations. So that it's not clear what it should return.
Basically we have two options here.
1. Introduce new "SAVED" constant. Something like SAVED_SKIPPED
2. Refactor CommentForm to not check permissions in submit handler.

πŸ› Bug report
Status

Active

Version

10.1 ✨

Component
CommentΒ  β†’

Last updated 2 days ago

Created by

πŸ‡·πŸ‡ΊRussia Chi

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.69.0 2024