Migrate.MigrateCommentUnitTest is failing on PHP 7.4+, test divulges error comming from core

I think that these test errors are caused by the Migrate module, not D7 core.

In wine.install.inc there is a function migrate_example_wine_fields() which defines display modes:

      'display' => array(
        'full' => array(
          'label' => 'hidden',
          'type' => 'image__large',
          'settings' => array(),
          'weight' => -1,
        ),
        'teaser' => array(
          'label' => 'hidden',
          'type' => 'image_link_content__medium',
          'settings' => array(),
          'weight' => -1,
        ),
        'rss' => array(
          'label' => 'hidden',
          'type' => 'image__large',
          'settings' => array(),
          'weight' => -1,
        ),
        'search_index' => array(
          'label' => 'hidden',
          'type' => 'image__large',
          'settings' => array(),
          'weight' => -1,
        ),
        'search_results' => array(
          'label' => 'hidden',
          'type' => 'image__large',
          'settings' => array(),
          'weight' => -1,
        ),
      ),

The problem seems to be in types definition in all of these display modes.

This is not valid:

'type' => 'image__large',

It should be:

'type' => 'image',
'settings' => array('image_style' => 'large', 'image_link' => ''),

(see: https://git.drupalcode.org/project/drupal/-/blob/7.x/profiles/standard/standard.install#L381)

And also this is not valid:

'type' => 'image_link_content__medium',

It should be:

'type' => 'image',
'settings' => array('image_style' => 'medium', 'image_link' => 'content'),

(see: https://git.drupalcode.org/project/drupal/-/blob/7.x/profiles/standard/standard.install#L387)

---------

And the same problem is in the beer.install.inc file in the migrate_example_beer_image() function.

If these definitions are changed, the warnings seems to be gone.

Thanks @poker10 , I've made a patch using your suggestions above.

Thanks @poker10 ! Great sleuthing!

Automatically closed - issue fixed for 2 weeks with no activity.