- Status changed to Needs review
almost 2 years ago 4:44am 10 March 2023 - 🇮🇳India gayatri chahar
I submitted patch with some changes
Please review it
Thanks - 🇮🇳India dharmeshbarot Gujarat
added content in hook_help()! needs review
- 🇵🇭Philippines paraderojether
@ gayatri chahar
I applied patch #3 against Private Message Invites 1.0.4 with Drupal core version 9.4.7 and I am getting this error:
"Fatal error: Cannot redeclare private_message_help() (previously declared in /var/www/docroot/modules/private_message/private_message.module:481) in /var/www/docroot/modules/private_message_invite/private_message_invite.module on line 22"
The error can be fixed by renaming the private_message_help into 'private_message_invite_help'.
Please check.
Thank You.
- 🇮🇳India gayatri chahar
Addressed #5 comment and made changes in patch
Thanks @paraderojether - 🇵🇭Philippines paraderojether
Hi @gayatri chahar
I reviewed patch #7 and there's another concern about this patch is getting this Warning: file_get_contents(/var/www/docroot/modules/private_message_invite/README.md): Failed to open stream: No such file or directory in private_message_invite_help() (line 25 of /var/www/docroot/modules/private_message_invite/private_message_invite.module). I just realized that README.txt is not yet replaced with README.md, and this warning can be fixed by replacing the README.md with => README.txt in this line $text = file_get_contents(__DIR__ . '/README.md');.
Could you update the patch?
Thanks! - Status changed to Needs work
almost 2 years ago 2:45am 14 March 2023 - First commit to issue fork.
- Assigned to himanshu_jhaloya
- Status changed to Needs review
almost 2 years ago 5:16am 14 March 2023 - Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 6:48am 14 March 2023 - 🇵🇭Philippines paraderojether
Hi @ himanshu_jhaloya
I applied patch #12 and this now works fine for me.
Thank You.