- Merge request !1Issue #3333384: Why the need of layout_builder_reorder_module_implements_alter? → (Merged) created by tim-diels
- Assigned to Grimreaper
- 🇫🇷France Grimreaper France 🇫🇷
Hello,
As currently the reorder links are wrapped into a container:
$sections[$key]['rearrange'] = [ '#type' => 'container', ];
The hook has currently no impact so it can be removed.
I think to open another branch to get rid of this container wrapper.
If the reorder links needs to appear last (which I agree is better), then setting a weight on it will do it properly.
-
grimreaper →
committed f809c8b1 on 1.0.x authored by
tim-diels →
Issue #3333384 by tim-diels, aspilicious, grimreaper: Remove...
-
grimreaper →
committed f809c8b1 on 1.0.x authored by
tim-diels →
- 🇫🇷France Grimreaper France 🇫🇷
Ok, the problem is that "layout-builder__section" key does not have a weight. So if putting weight on links it appears after the section.
✨ Allow changing the layout of an existing section in Layout Builder UI Needs work is also proposing to put links into a dedicated container so that no side effect on other stuff.
I would prefer to not act on the links so themers can alter LB element to do their own reordering. Especially if a lot of other patches on core and other contrib modules are present.
This is very side effect prone.