- Status changed to Needs work
about 2 years ago 2:17am 25 January 2023 - 🇧🇷Brazil renatog Campinas
Hello. I was reading here the README but I think it can be improved.
Look that there are some duplicated informations there:
#1 On description there is a sentence
No additional
contributed modules are required to install.#2 On session "Requirements" also have this information:
This module requires no modules outside of Drupal core.
#3 On session "Configuration" there is a duplicated information as well:
The module has no modifiable settings - There is no configuration.
So I think it can be improved
- Status changed to Needs review
about 2 years ago 2:27am 25 January 2023 - 🇧🇷Brazil renatog Campinas
Updated the MR with these improvements in the README: https://git.drupalcode.org/project/openchurch_core/-/merge_requests/3
- 🇮🇳India rinku jacob 13 Kerala
I have reviewed the merge request !3. I can see the changes on the file which is made by @Renatog. Thanks @shubham and @Renatog. Adding screenshot for the reference. Need +1RTBC
- Status changed to RTBC
about 2 years ago 6:04am 25 January 2023 - 🇧🇷Brazil renatog Campinas
So based on feedback from #8, updating the status to RTBC
- 🇺🇸United States drupalninja99
I also want to link to the OpenChurch Gitbook from the README which has full details: https://openchurch.gitbook.io/guide/
- Status changed to Needs work
about 2 years ago 7:29pm 25 January 2023 - 🇧🇷Brazil renatog Campinas
Makes sense - Updating as "Needs Works" to include the Gitbook
- @renatog opened merge request.
- Status changed to Needs review
about 2 years ago 7:57pm 25 January 2023 - 🇧🇷Brazil renatog Campinas
Added the Gitbook. MR updated: https://git.drupalcode.org/project/openchurch_core/-/merge_requests/5#no...
- Status changed to RTBC
about 2 years ago 9:52pm 25 January 2023 - 🇧🇷Brazil renatog Campinas
Ah yeah, I think the branch of MR was updated with the code from branch
3.0.x
right?!Makes sense for me
-
drupalninja99 →
committed 959f8958 on 3.0.x authored by
RenatoG →
Issue #3332944: Add README.md file.
-
drupalninja99 →
committed 959f8958 on 3.0.x authored by
RenatoG →
- 🇧🇷Brazil renatog Campinas
Great! @drupalninja99 since it was committed into 3.0.x, could you please close the ticket as "fixed", please?
It'll reduce the open items in the issue queue
- Status changed to Fixed
about 2 years ago 10:37pm 25 January 2023 Automatically closed - issue fixed for 2 weeks with no activity.