- Status changed to Needs work
almost 2 years ago 3:56pm 17 January 2023 - Merge request !34Issue #3332930: use_imagecache_root doesn't work with webp β (Closed) created by godotislate
- π΅π±Poland dziabodo
Hey,
The problem with webp is that we don't give drupal the ability to generate the image, when we invert the arrays and call webp first, drupal will capture the missing image and generate it.
- πΊπΈUnited States smustgrave
@dziabodo
Thank you just want to confirm the MR and current 2.0.x-dev did not fix it for you?
- π΅π±Poland dziabodo
Yeah @smustgrave, problem still existed, but after revers array images back
- πΊπΈUnited States smustgrave
Thank you for checking. Can someone confirm if $17 solves the issues for them? DOn't have webP setup locally or on any projects.
- π©πͺGermany antoniya
#17 solved the issue for us but I do have to note that we are using core's built-in convert effect for WebP image styles and not the contributed module (as described in the original issue for WebP support linked in the IS).
- πΊπΈUnited States smustgrave
Okay if no objection by tomorrow I'll merge in #17. Will track under the Meta if we can get plenty of testing.
- @smustgrave opened merge request.
-
smustgrave β
committed bea4ebaa on 2.0.x
Issue #3332930: use_imagecache_root doesn't work with webp
-
smustgrave β
committed bea4ebaa on 2.0.x
- Status changed to RTBC
almost 2 years ago 2:52pm 31 January 2023 - πΊπΈUnited States smustgrave
Merged #17. If still an issue please reopen!
If we can get heavy testing could probably do another release for https://www.drupal.org/project/stage_file_proxy/issues/3334239 π± 2.0.3 Release Fixed
- Status changed to Fixed
almost 2 years ago 2:53pm 31 January 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 10:13am 28 February 2023 - πΈπͺSweden kevinn
Don't get how you guys got this to work, the checkFileOrigin method is looking for:
public://example.webp
public://exampleWhich nether exists because the webp is being created by the webp module as a image style and of course public://example does not exist.
Here is a patch that checks for other file extensions.
Btw im using responsive images, maybe thats why it does not work for me. - π¨πSwitzerland Lukas von Blarer
Yes, same for me as described in #29. Could a maintainer re-open this please?
- πΊπΈUnited States smustgrave
Would recommend opening a new ticket explaining your issue.
- π¨πSwitzerland Lukas von Blarer
Ok, did so: π use_imagecache_root doesn't work with webp Fixed I used the exact same title and IS, since I am the creator of this issue as well. Feel free to change it accordingly.