Add more configuration options for error & email details

Why assign an error ticket to someone assign? Can't someone else deal with it?

Yes of course anyone can do that! :) I just asked @Grevil to do it. But feel free, so @Grevil or someone else can review this. Thanks @nevergone!

Implementing these options now!

A quick suggestion for the default subject and body messages with included tokens (I tried to go after the on-page Drupal error look for better understanding):

PHP [watchdog_mailer:type] at [site:url]

A site reported the following:

[watchdog_mailer:type]: [watchdog_mailer:message] in [watchdog_mailer:function] (line [watchdog_mailer:line] of [watchdog_mailer:file]).

Channel: [watchdog_mailer:channel]
Severity Level: [watchdog_mailer:level]
Caused by user: [watchdog_mailer:user] (IP: [watchdog_mailer:user_ip])
At timestamp: [watchdog_mailer:date_time]

Links:
[site:url]
[watchdog_mailer:link]

Full backtrace:
[watchdog_mailer:backtrace]

Also, here's an example of a filled out version of this, and I think it looks quite clear and understandable:

PHP Error at mysite.com

A site reported the following:

Error: Undefined function myFunc() in myOtherFunc() (line 12 of web/core/modules/custom/mymodule/mymodule.module).

Channel: php
Severity Level: 4
Caused by user: 2367 (IP: 123.456.789.012)
At timestamp: 1234567890

Links:
mysite.com
mysite.com/admin/config/development/logging

Full backtrace:
bla/bla/bla/bla line 1
bla/bla/bla/bla line 2
bla/bla/bla/bla line 3
bla/bla/bla/bla line 4
bla/bla/bla/bla line 5
bla/bla/bla/bla line 6
bla/bla/bla/bla line 7

Well, the new functionality has been implemented and is working for me!
Of course this still needs the addition of proper tests, yet I thought better let someone take a look at this first! Perhaps we should outsource the tests to 📌 Add basic test coverage Needs work anyway?

@LRWebks nice! I like it!

For the default subject I'd even use:

PHP [watchdog_mailer:type]: "[watchdog_mailer:message]" at [site:url]

Yes, that look better than before - nice suggestion! :)

@LRWebks: I added further comments :)

Afterwards this should be fine! We should also add some simple tests for the config form, I guess?

All threads are resolved again, back to review!

Currently, I am unsure of how to test this, as generating a PHP error manually to receive the email causes PHPUnit to stop the test... Should we "Postpone" / "Needs Review" and outsource the test to 📌 Add basic test coverage Needs work / keep this issue as is?

Yes, solve this in the other issue, but list the tests to implement explicitly.

Now that this issue is done and your review didn't raise any more problems, RTBC?

We should get some final feedback, but yes I think it's close to be RTBC! Thank you @LRWebks! Well done!

Final improvements, works great! :)

Great work! RTBC!

Just saw we can remove the @date.formatter dependency as token solves this for us now.

Finally done! I removed the hard dependency on token module and instead use progressive enhancement. PHP tokens are optional and clearly separated now.

Really useful feature, I think. Ready for final review!

@nevergone or @LRWebks or anyone else, please have a try :)

I tested it and it seems good.

@anybody can you please fix merge conflicts?

I will do it today.

All resolved! :)

Needs test, related issue: 📌 Add basic test coverage Needs work

Thanks!!

Tests should be written if this is resolved: 📌 Add basic test coverage Needs work

Thanks @nevergone sorry I got you wrong, I thought you wanted to implement the tests in the other issue.

Rebased branch from latest 2.0.x commit and reformat code: https://git.drupalcode.org/project/watchdog_mailer/-/commits/3332921-add...

Please test and review.

Needs another rebase -.-

@Anybody:

Please use 3332921-add-more-configuration--squash-merge branch. This is squashed merge from 3332921-add-more-configuration branch and add reformat code with Drupal coding standards, finally fix test with new functions.

@nevergone: Thanks! If this work for you, you may merge that branch. I tested this before the other changes and it works perfectly well. so RTBC from my side, despite the rebase.

You may just use this commit message to combine the merge with this issue:

Issue #3332921 by Anybody, LRWebks, Grevil, nevergone: Add more configuration options for error & email details

PERFECT, thank you! :)

I think we all did a quite good job here recently and can be proud.

Anybody → closed merge request !9

Automatically closed - issue fixed for 2 weeks with no activity.