Created on 12 January 2023, about 2 years ago
Updated 2 March 2023, almost 2 years ago

Running phpcs returns

FILE: /Users/tesboss/_PROJECTS/2023/mdb-drupal8/docroot/modules/contrib/webform_jira_service_desk/webform_jira_service_desk.module
----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
 15 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 25 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 25 | ERROR   | [ ] Missing parameter comment
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/tesboss/_PROJECTS/2023/mdb-drupal8/docroot/modules/contrib/webform_jira_service_desk/README.md
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 3 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------


FILE: /Users/tesboss/_PROJECTS/2023/mdb-drupal8/docroot/modules/contrib/webform_jira_service_desk/webform_jira_service_desk.info.yml
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/tesboss/_PROJECTS/2023/mdb-drupal8/docroot/modules/contrib/webform_jira_service_desk/src/Form/WebformJiraFieldDeleteForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 1 WARNING AFFECTING 10 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
  13 | ERROR   | [x] Doc comment short description must end with a full stop
  16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
  19 | ERROR   | [ ] Missing short description in doc comment
  57 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 110 | ERROR   | [ ] Missing short description in doc comment
 111 | ERROR   | [ ] Missing parameter comment
 113 | ERROR   | [ ] Description for the @return value is missing
 124 | ERROR   | [ ] Missing short description in doc comment
 125 | ERROR   | [ ] Description for the @return value is missing
 136 | ERROR   | [ ] Doc comment is empty
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/tesboss/_PROJECTS/2023/mdb-drupal8/docroot/modules/contrib/webform_jira_service_desk/src/Form/WebformJiraFieldForm.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 33 ERRORS AND 2 WARNINGS AFFECTING 32 LINES
-----------------------------------------------------------------------------------------------------------------------------------
  16 | ERROR   | [x] Doc comment short description must end with a full stop
  19 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
  24 | ERROR   | [ ] Missing short description in doc comment
  29 | ERROR   | [ ] Missing short description in doc comment
  34 | ERROR   | [ ] Missing short description in doc comment
  42 | ERROR   | [ ] Missing parameter comment
  43 | ERROR   | [ ] Missing parameter comment
 223 | ERROR   | [x] Doc comment short description must end with a full stop
 225 | ERROR   | [ ] Missing parameter comment
 226 | ERROR   | [ ] Missing parameter comment
 228 | ERROR   | [ ] Description for the @return value is missing
 231 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 242 | ERROR   | [x] Doc comment short description must end with a full stop
 244 | ERROR   | [ ] Description for the @return value is missing
 260 | ERROR   | [x] Doc comment short description must end with a full stop
 262 | ERROR   | [ ] Description for the @return value is missing
 274 | ERROR   | [x] Doc comment short description must end with a full stop
 276 | ERROR   | [ ] Missing parameter comment
 278 | ERROR   | [ ] Description for the @return value is missing
 290 | ERROR   | [x] Doc comment short description must end with a full stop
 292 | ERROR   | [ ] Missing parameter comment
 294 | ERROR   | [ ] Description for the @return value is missing
 313 | ERROR   | [x] Doc comment short description must end with a full stop
 315 | ERROR   | [ ] Missing parameter comment
 317 | ERROR   | [ ] Description for the @return value is missing
 328 | ERROR   | [x] Doc comment short description must end with a full stop
 330 | ERROR   | [ ] Missing parameter type
 330 | ERROR   | [x] Parameter comment must be on the next line
 331 | ERROR   | [ ] Missing parameter type
 331 | ERROR   | [x] Parameter comment must be on the next line
 333 | ERROR   | [ ] Description for the @return value must be on the next line
 346 | ERROR   | [ ] Missing short description in doc comment
 347 | ERROR   | [ ] Missing parameter comment
 347 | ERROR   | [ ] Missing parameter type
 349 | ERROR   | [ ] Description for the @return value is missing
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/tesboss/_PROJECTS/2023/mdb-drupal8/docroot/modules/contrib/webform_jira_service_desk/src/Form/WebformJiraFieldEditForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR   | [x] Doc comment short description must end with a full stop
 13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 39 | WARNING | [ ] Unused variable $mapping.
 47 | ERROR   | [x] The first index in a multi-value array must be on a new line
 48 | ERROR   | [x] Array indentation error, expected 8 spaces but found 6
 48 | ERROR   | [x] Each index in a multi-line array must be on a new line
 48 | ERROR   | [x] Closing parenthesis of array declaration must be on a new line
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/tesboss/_PROJECTS/2023/mdb-drupal8/docroot/modules/contrib/webform_jira_service_desk/src/Form/WebformJiraConfigurationForm.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 16 ERRORS AND 3 WARNINGS AFFECTING 17 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
  14 | ERROR   | [x] Doc comment short description must end with a full stop
 106 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 107 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 108 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 109 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 112 | ERROR   | [x] Array closing indentation error, expected 6 spaces but found 8
 145 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 148 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4 spaces
 265 | ERROR   | [ ] Missing short description in doc comment
 266 | ERROR   | [ ] Description for the @return value is missing
 282 | ERROR   | [x] Doc comment short description must end with a full stop
 284 | ERROR   | [ ] If there is no return value for a function, there must not be a @return tag.
 284 | ERROR   | [ ] Description for the @return value is missing
 287 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
 293 | ERROR   | [x] Doc comment short description must end with a full stop
 295 | ERROR   | [ ] Missing parameter comment
 297 | ERROR   | [ ] If there is no return value for a function, there must not be a @return tag.
 297 | ERROR   | [ ] Description for the @return value is missing
 300 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/tesboss/_PROJECTS/2023/mdb-drupal8/docroot/modules/contrib/webform_jira_service_desk/src/Form/JiraServiceDeskConfigurationForm.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
  17 | ERROR   | [x] Doc comment short description must end with a full stop
  47 | ERROR   | [ ] Missing parameter comment
  48 | ERROR   | [ ] Missing parameter comment
  49 | ERROR   | [ ] Missing parameter comment
  50 | ERROR   | [ ] Missing parameter comment
 104 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use '' quotes instead
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/tesboss/_PROJECTS/2023/mdb-drupal8/docroot/modules/contrib/webform_jira_service_desk/src/JiraServiceDeskService.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 49 ERRORS AND 8 WARNINGS AFFECTING 49 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  17 | ERROR   | [x] Doc comment short description must end with a full stop
  21 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  29 | ERROR   | [ ] Missing short description in doc comment
  34 | ERROR   | [ ] Missing short description in doc comment
  39 | ERROR   | [ ] Missing short description in doc comment
  44 | ERROR   | [ ] Missing short description in doc comment
  49 | ERROR   | [ ] Missing short description in doc comment
  57 | ERROR   | [ ] Missing parameter comment
  58 | ERROR   | [ ] Missing parameter comment
  59 | ERROR   | [ ] Missing parameter comment
  60 | ERROR   | [ ] Missing parameter comment
  76 | ERROR   | [x] Doc comment short description must end with a full stop
  79 | ERROR   | [x] Return comment indentation must be 3 spaces, found 6 spaces
 104 | ERROR   | [x] Doc comment short description must end with a full stop
 106 | ERROR   | [ ] Missing parameter comment
 109 | ERROR   | [x] Return comment indentation must be 3 spaces, found 6 spaces
 123 | ERROR   | [x] Inline comments must start with a capital letter
 123 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 134 | ERROR   | [x] Doc comment short description must end with a full stop
 136 | ERROR   | [ ] Missing parameter comment
 137 | ERROR   | [ ] Missing parameter comment
 140 | ERROR   | [x] Return comment indentation must be 3 spaces, found 4 spaces
 158 | ERROR   | [x] Inline comments must start with a capital letter
 158 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 165 | ERROR   | [x] Doc comment short description must end with a full stop
 167 | ERROR   | [ ] Missing parameter comment
 169 | ERROR   | [ ] Description for the @return value is missing
 201 | ERROR   | [ ] The array declaration extends to column 162 (the limit is 80). The array content should be split up over multiple lines
 217 | ERROR   | [x] Doc comment short description must end with a full stop
 219 | ERROR   | [ ] Missing parameter comment
 220 | ERROR   | [ ] Missing parameter comment
 222 | ERROR   | [ ] Description for the @return value is missing
 224 | ERROR   | [ ] Type hint "\Drupal\webform\WebformSubmissionInterface" missing for $submission
 224 | ERROR   | [ ] Type hint "array" missing for $fields
 235 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 235 | ERROR   | [x] Doc comment short description must end with a full stop
 237 | ERROR   | [ ] Missing parameter comment
 237 | ERROR   | [ ] Missing parameter type
 238 | ERROR   | [ ] Missing parameter comment
 240 | ERROR   | [ ] Description for the @return value is missing
 241 | ERROR   | [x] Separate the @return and @throws sections by a blank line.
 245 | WARNING | [ ] Exceptions should not be translated
 287 | WARNING | [ ] Exceptions should not be translated
 292 | ERROR   | [x] Doc comment short description must end with a full stop
 296 | ERROR   | [ ] Missing parameter comment
 296 | ERROR   | [ ] Missing parameter type
 297 | ERROR   | [ ] Missing parameter comment
 299 | ERROR   | [ ] Description for the @return value is missing
 320 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
 320 | ERROR   | [x] Doc comment short description must end with a full stop
 322 | ERROR   | [ ] If there is no return value for a function, there must not be a @return tag.
 322 | ERROR   | [ ] Description for the @return value is missing
 325 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 329 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 333 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 338 | ERROR   | [x] Expected 1 blank line after function; 0 found
 339 | ERROR   | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------
📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇺Australia VladimirAus Brisbane, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @kkalashnikov opened merge request.
  • 🇮🇳India kkalashnikov Ghaziabad, India

    Fixed rest of the phpcs issues

  • 🇮🇳India Akram Khan Cuttack, Odisha

    FILE: ...l9.5.x/drupal/modules/contrib/webform_jira_service_desk/webform_jira_service_desk.info.yml
    ------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------
    1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging
    | | automatically
    1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging
    | | automatically
    1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging
    | | automatically
    ------------------------------------------------------------------------------------------------

    FILE: ...rupal9.5.x/drupal/modules/contrib/webform_jira_service_desk/src/JiraServiceDeskService.php
    ------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ------------------------------------------------------------------------------------------------
    401 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
    ------------------------------------------------------------------------------------------------

    Still there are issue remaining in this 2 file

  • 🇮🇳India Akram Khan Cuttack, Odisha

    Fixed remaining Issue

  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India Akram Khan Cuttack, Odisha
  • First commit to issue fork.
  • Status changed to Fixed almost 2 years ago
  • 🇦🇺Australia au_dave Adelaide
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024