- πΊπΈUnited States cboyden
Here's a patch that adds (translatable) hidden text, and hides the Γ HTML entity.
@dsnopek the CTools modal is doing a bit of belt-and-suspenders. The aria-label will override all of the text in the button, so it's not necessary to do both that and the hidden text. For consistency's sake, it would be best to use the same method in both places.
There is some debate over which method is best overall. Some recent commentary supports using hidden text instead of aria-label - see aria-label Does Not Translate.
If that sounds reasonable, I can update the patch to do the same thing in the CTools modal.
-
doxigo β
committed f3fe3d06 on 7.x-3.x authored by
cboyden β
Issue #3332429 by cboyden, dsnopek: Incorrect ARIA markup for...
-
doxigo β
committed f3fe3d06 on 7.x-3.x authored by
cboyden β
- Status changed to Fixed
over 1 year ago 8:53am 8 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 5:14pm 13 March 2023 - πΊπΈUnited States cboyden
There was a typo in the committed patch - see updated patch and interdiff attached.
- Status changed to Needs review
over 1 year ago 6:06pm 13 March 2023 - Status changed to Closed: outdated
3 months ago 11:10am 21 June 2024 No longer supported/outdated, closing - feel free to open a MR if applicable.