- Status changed to Needs work
over 1 year ago 1:12pm 16 February 2023 - π«π·France Grimreaper France π«π·
Hi,
Nice catch!
This comes from
$json['meta']['count']
, so it depends of the type of count in the JSON API response on the server website.I have tested and in my case it is an int and I reproduce the error.
I guess this is the type of $remoteChannelCount in the ImportContext that should be changed to int, this is way more logical.
I think at the time I wrote that, I used a string for the
if (empty)
statement in ImportService.So I will provide a MR that change the type of the property and so the getter etc. And force a type int when getting the value from JSON API response.
- @grimreaper opened merge request.
-
Grimreaper β
committed 887489cc on 8.x-3.x
Issue #3332394 by BenStallings, Grimreaper: Change $remote_channel_count...
-
Grimreaper β
committed 887489cc on 8.x-3.x
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 1:29pm 16 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.