Change $remote_channel_count to int

Created on 10 January 2023, over 1 year ago
Updated 16 February 2023, over 1 year ago

Problem/Motivation

The ImportContext->setRemoteChannelCount() method requires its parameter to be a string, but the PullForm->importChannel() method submits $storage['remote_channel_count'] without ensuring that it is a string.

Steps to reproduce

I'm not sure why my site has an integer stored in that variable, but it doesn't seem like an unreasonable way to count remote channels. :shrug:

Proposed resolution

In PullForm->importChannel(), add a type hint to change $storage['remote_channel_count'] to a string before submitting it to ImportContext->setRemoteChannelCount().

Remaining tasks

make a patch.

πŸ› Bug report
Status

Fixed

Version

3.0

Component

Entity share client

Created by

πŸ‡ΊπŸ‡ΈUnited States BenStallings

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024