- First commit to issue fork.
- Status changed to Needs work
almost 2 years ago 2:41pm 9 February 2023 - 🇩🇪Germany Anybody Porta Westfalica
Thank you very much @rp7!
Could you perhaps provide the changes as MR?Should we have additional tests or is everything covered?
Thanks! :)
- @grevil opened merge request.
- Status changed to RTBC
almost 2 years ago 1:43pm 13 February 2023 - 🇩🇪Germany Grevil
Alright all finished and tested:
- The submission works as expected and the settings are unique to the vocabulary and behave as expected (tested "enabled" true / false and "message" empty / default / changed)
- The update hook works flawlessly
- The test coverage is fairly decent! No need to add further tests for now (Although we could create a follow up issue to add a few more)
- 🇩🇪Germany Anybody Porta Westfalica
Great work @rp7 and @Grevil! :) Made some minor textual improvements, now I think it's ready to go.
@Grevil says it's fine, the tests say it's fine, so it's merge time! :)
- Status changed to Fixed
almost 2 years ago 4:56pm 13 February 2023 - 🇩🇪Germany Anybody Porta Westfalica
Fixed! We'll keep this in .dev for some weeks.
Automatically closed - issue fixed for 2 weeks with no activity.