Convert global configuration to vocabulary third party settings

Created on 10 January 2023, almost 2 years ago
Updated 13 February 2023, almost 2 years ago

Currently all (vocabulary-specific) configuration is stored in the global configuration (taxonomy_unique.settings). A more proper way of storing vocabulary-specific configuration is as a third party setting on the vocabulary object itself.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇧🇪Belgium rp7

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Status changed to Needs work almost 2 years ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Thank you very much @rp7!
    Could you perhaps provide the changes as MR?

    Should we have additional tests or is everything covered?

    Thanks! :)

  • @grevil opened merge request.
  • Status changed to RTBC almost 2 years ago
  • 🇩🇪Germany Grevil

    Alright all finished and tested:

    • The submission works as expected and the settings are unique to the vocabulary and behave as expected (tested "enabled" true / false and "message" empty / default / changed)
    • The update hook works flawlessly
    • The test coverage is fairly decent! No need to add further tests for now (Although we could create a follow up issue to add a few more)
  • 🇩🇪Germany Anybody Porta Westfalica

    Great work @rp7 and @Grevil! :) Made some minor textual improvements, now I think it's ready to go.

    @Grevil says it's fine, the tests say it's fine, so it's merge time! :)

  • Status changed to Fixed almost 2 years ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Fixed! We'll keep this in .dev for some weeks.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024