- π«π·France Grimreaper France π«π·
Hi,
I made some code review comments.
Also please rebase the MR.
Module is not able to import large files, bigger than PHP memory limits.
Dont use file_get_contents() as it loads entire file into PHP memory.
Options:
Use for example copy function - https://www.php.net/manual/en/function.copy.php
Use guzzle sink option - https://docs.guzzlephp.org/en/stable/request-options.html#sink
Refactor \Drupal\entity_share_client\Plugin\EntityShareClient\Processor\PhysicalFile
Needs work
3.0
Entity share client
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Hi,
I made some code review comments.
Also please rebase the MR.