- Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.
A problem was discovered while working on
🐛
GitExcluder should not ignore .git directories that belong to packages installed by Composer
Fixed
, consider a case when the composer.json
in active directory is deleted somehow and we call StatusCheckTrait::runStatusCheck
so the first event to be dispatched will be CollectIgnoredPathsEvent
which will error out as it tries to get the active composer and then we dispatch StatusCheckEvent
.
The problem with swapping the order of dispatch is that we are sending the excluded paths with the StatusCheckEvent
which is required by the \Drupal\package_manager\Validator\SymlinkValidator
.
The code snippet which needs to be changed
$ignored_paths = new CollectIgnoredPathsEvent($stage);
$event_dispatcher->dispatch($ignored_paths);
$event = new StatusCheckEvent($stage, $ignored_paths->getAll());
$event_dispatcher->dispatch($event);
$results = $event->getResults();
Fixed
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Automatically closed - issue fixed for 2 weeks with no activity.