Automatically closed - issue fixed for 2 weeks with no activity.
- π©πͺGermany Anybody Porta Westfalica
Same requirement came up once again: π¬ Impossible to cancel an order Fixed
Please read the comments over there. While a returned order should indeed not be "canceled", but "returned" or something like this, there are still cases where it's indeed canceled. I really think we should reopen this discussion (but not as major). Or leave the other issue open, if that fits better.
- πΊπΈUnited States lisastreeter
The behavior of an existing Commerce order workflow should not be changed. Existing commerce sites already running in production will have custom Event subscribers, Guards, etc. Moving an order to the "Completed" state may trigger business logic like invoicing. (Or affect other business logic related to inventory, accounting, etc., as mentioned above.)
Existing e-commerce sites should not be forced to rework their working/tested custom code so that some new Drupal Commerce websites can have a workflow that allows cancelation from the Completed state.
Especially when it is very simple to create a new workflow. Yes, a custom module is needed. But it's just some configuration yaml, not custom code or anything complex. Just one folder for the module, one yaml file to define the module, and one yaml file for the workflow: https://docs.drupalcommerce.org/commerce2/developer-guide/orders/workflo...
No actual "coding" is needed. Just start with a copy of an existing workflow and modify it as you like, with a new name/label.(For various logic to work as is in Commerce Core, you should keep the 'draft' 'canceled', 'completed' state IDs as is as well as the 'place' transition.)
- π©πͺGermany Anybody Porta Westfalica
@lisastreeter also totally agree with that, but don't agree that "Completed" is the only "End".
You're right that it might not be the same end and we should talk about a different "canceled" here, as written in https://www.drupal.org/project/commerce/issues/3381411#comment-15194858 β¨ Allow canceling a completed order (Workflows) Closed: duplicate but I'm fine with the custom workflows, just wanted to add that I see cases where it would make sense to have the chance to have one more state behind / besides completed.