- 🇮🇳India Jay Jangid
Thanks @noorulshameera for creating patch.
But after applied Patch ,it shows some erros.error: patch failed: files_upload.module:11 error: files_upload.module: patch does not apply error: patch failed: src/Form/FilesUploadForm.php:14 error: src/Form/FilesUploadForm.php: patch does not apply
Moving it to Need work
- First commit to issue fork.
- Assigned to sourabhjain
- Status changed to Needs review
almost 2 years ago 10:49am 24 January 2023 - Issue was unassigned.
- 🇮🇳India sourabhjain
I have resolved the below mentioned PHPCS issue.
sourabhjain@LPT-SOURABH files_upload % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig . FILE: /Users/sourabhjain/www/drupal/modules/contrib/files_upload/README.md -------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------- 14 | WARNING | Line exceeds 80 characters; contains 119 characters -------------------------------------------------------------------------- FILE: /Users/sourabhjain/www/drupal/modules/contrib/files_upload/files_upload.module ------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------ 6 | ERROR | [x] There must be exactly one blank line after the file comment ------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------ FILE: /Users/sourabhjain/www/drupal/modules/contrib/files_upload/src/Form/FilesUploadForm.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 47 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 93 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 97 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 108 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 119 | WARNING | Unused variable $file_name. ------------------------------------------------------------------------------------------------------------------------------------------
Please review it.
- Assigned to Charchil Khandelwal
- 🇮🇳India Charchil Khandelwal
Thanks @sourabhjain , patch #10 applied cleanly, all errors and warnings are fixed.
Moving to RTBC. - Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 11:22am 24 January 2023 - Assigned to radheymkumar
- Status changed to Fixed
4 months ago 7:12am 14 July 2024 - Status changed to Fixed
4 months ago 7:12am 14 July 2024