- Issue was unassigned.
- Merge request !12Issue #3329755: Drupal Coding Standards Issues | phpcs → (Closed) created by Charchil Khandelwal
- Status changed to RTBC
about 2 years ago 6:36am 23 January 2023 - 🇮🇳India Charchil Khandelwal
Patch #2 applied cleanly, and all errors and warnings are fixed.
So moving it to RTBC.
Thanks - First commit to issue fork.
- last update
about 1 year ago 1 pass - Status changed to Fixed
about 1 year ago 8:04am 25 January 2024 - 🇺🇦Ukraine AstonVictor
The MR doesn't fix all the issues.
Line src/SimpleBlockEditForm.php ------ ----------------------------------------------------------------------------------------------------------- 69 Method Drupal\simple_block\SimpleBlockEditForm::save() should return int but return statement is missing. FILE: /var/www/html/web/modules/contrib/simple_block/modules/simple_block_layout_builder/src/Event/Subscriber/SimpleBlockAddControllerSubscriber.php ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\NestedArray. FILE: /var/www/html/web/modules/contrib/simple_block/modules/simple_block_layout_builder/tests/scr/FunctionalJavascript/SimpleBlockLayoutBuilderTest.php -------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\node\Entity\NodeType. FILE: /var/www/html/web/modules/contrib/simple_block/tests/src/Functional/SimpleBlockTest.php ----------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\block\Functional\AssertBlockAppearsTrait.Created a new MR with all the fixes. Merged in 8.x-1.x branch.
Automatically closed - issue fixed for 2 weeks with no activity.