Drupal 10 compatibility

Created on 26 December 2022, almost 2 years ago
Updated 3 March 2023, almost 2 years ago

Problem/Motivation

Drupal 10 was recently released. Let's add explicit support for it in this module.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

heddn Nicaragua

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇧🇪Belgium tim-diels Belgium 🇧🇪

    Thanks already for the work done!

    But the sub module sms_phone_number should also be updated regarding the once library.

    And after manually testing I get the error: Uncaught TypeError: once(...).each is not a function and the flags are not shown.

  • Status changed to RTBC almost 2 years ago
  • 🇧🇪Belgium tim-diels Belgium 🇧🇪

    I've updated the patch to also include the JS in the submodule.

    Upgrade status is green.
    Manual testings seems fine.

  • 🇧🇪Belgium tim-diels Belgium 🇧🇪
  • 🇧🇪Belgium tim-diels Belgium 🇧🇪

    To fast. Updated patch.

    • tim-diels committed 1f15a374 on 8.x-1.x
      Issue #3329686 by PrabuEla, tim-diels, heddn: Drupal 10 compatibility
      
  • Status changed to Fixed almost 2 years ago
  • 🇧🇪Belgium tim-diels Belgium 🇧🇪

    Thanks everyone!

  • Status changed to Needs work almost 2 years ago
  • heddn Nicaragua

    On really small nit. And maybe it doesn't matter. And this is looking really good. Thanks for catching the sms omissions. We weren't using it so I forgot to check it.

    --- a/js/phone-number-form-element.js
    +++ b/js/phone-number-form-element.js
    
    --- a/modules/sms_phone_number/js/sms-phone-number-form-element.js
    +++ b/modules/sms_phone_number/js/sms-phone-number-form-element.js
    

    This is missing an update to the sms.libraries.yml to include core/once.

  • Status changed to Fixed almost 2 years ago
  • 🇧🇪Belgium tim-diels Belgium 🇧🇪

    As sms_phone_number/element has a dependency on phone_number/element, the dependency is not needed there I think?

  • heddn Nicaragua

    It is a minor thing. But since sms uses once directly and (maybe) someday element might stop using it, it would be safer to include all direct dependencies in sms. But not a huge issue either way. It is a small nit. Thanks for taking this over the finish line.

  • 🇧🇪Belgium tim-diels Belgium 🇧🇪

    I'll create a follow up issue to address this and fix it there. Thank you also for setting this up to get things going!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024