Drupal 10 compatibility

Created on 26 December 2022, over 1 year ago
Updated 3 March 2023, over 1 year ago

Problem/Motivation

Drupal 10 was recently released. Let's add explicit support for it in this module.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

heddn Nicaragua

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    Thanks already for the work done!

    But the sub module sms_phone_number should also be updated regarding the once library.

    And after manually testing I get the error: Uncaught TypeError: once(...).each is not a function and the flags are not shown.

  • Status changed to RTBC over 1 year ago
  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    I've updated the patch to also include the JS in the submodule.

    Upgrade status is green.
    Manual testings seems fine.

  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ
  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    To fast. Updated patch.

  • Status changed to Fixed over 1 year ago
  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    Thanks everyone!

  • Status changed to Needs work over 1 year ago
  • heddn Nicaragua

    On really small nit. And maybe it doesn't matter. And this is looking really good. Thanks for catching the sms omissions. We weren't using it so I forgot to check it.

    --- a/js/phone-number-form-element.js
    +++ b/js/phone-number-form-element.js
    
    --- a/modules/sms_phone_number/js/sms-phone-number-form-element.js
    +++ b/modules/sms_phone_number/js/sms-phone-number-form-element.js
    

    This is missing an update to the sms.libraries.yml to include core/once.

  • Status changed to Fixed over 1 year ago
  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    As sms_phone_number/element has a dependency on phone_number/element, the dependency is not needed there I think?

  • heddn Nicaragua

    It is a minor thing. But since sms uses once directly and (maybe) someday element might stop using it, it would be safer to include all direct dependencies in sms. But not a huge issue either way. It is a small nit. Thanks for taking this over the finish line.

  • πŸ‡§πŸ‡ͺBelgium tim-diels Belgium πŸ‡§πŸ‡ͺ

    I'll create a follow up issue to address this and fix it there. Thank you also for setting this up to get things going!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024