Add option to change the PostGreSQL Schema during installation

🐛 Multiple issues when PostgreSQL is used with non-public schema Fixed has landed.

I've just created the change record and here is a patch that seems to be working correctly and also tests if it works during installation.

All code changes look good to me.
The option has been added to the installer.
Testing has been added.
The default.settings.php have been updated.
The CR and Is are in order.
For me it is RTBC.

The last submitted patch, 5: 3328215-5.patch, failed testing. View results →

There was a issue with the test bot, but that seems to be resolved. Patch still applies and also tests are still succeeding. Back to RTBC.

I was confused about where this is actually used, and why we were adding this to the documentation here, but 🐛 Multiple issues when PostgreSQL is used with non-public schema Fixed added this feature without documenting it.

1. +++ b/core/modules/pgsql/src/Driver/Database/pgsql/Install/Tasks.php
   @@ -313,6 +313,15 @@ public function getFormOptions(array $database) {
   +      // PostgreSQL's Max Identifier Length Is 63 Bytes.
   

   Title case is not appropriate here:

   // PostgreSQL's maximum identifier length is 63 characters.
   

2. +++ b/core/modules/pgsql/tests/src/Functional/InstallerNonDefaultSchemaTest.php
   @@ -0,0 +1,63 @@
   +    if ($connection_info['default']['driver'] !== 'pgsql') {
   +      // The schema option is only available for PostgreSQL.
   +      $this->markTestSkipped("This test does not support the {$connection_info['default']['driver']} database driver.");
   +    }
   

   Is this necessary now we have per-driver tests? Why would the MySQL tests run at all if we are in a Postgres CI environment?

Tried to address pointer 1.
Please review.

Thanks for working on this.

In addition to points from @longwave, there is at least one additional issue with the patch.

The new schema input field is not required. Therefore it could be left blank. In case you left that input blank, Drupal will not install, but throws an error:

Failed to CREATE a test table on your database server with the command CREATE TABLE {drupal_install_test} (id int NOT NULL PRIMARY KEY). The server reports the following message: SQLSTATE[42601]: Syntax error: 7 ERROR: zero-length delimited identifier at or near """" LINE 1: CREATE TABLE ""."drupal_install_test" (id int NOT NULL PRIMA... ^: CREATE TABLE ""."drupal_install_test" (id int NOT NULL PRIMARY KEY); Array ( ) .

When we compare it with the port input field, which is not required as well, Drupal will install in case you leave the port field empty. Therefore we need to either mark the schema field as required, or fix the additional handling of the value in case it is left empty (and use public instead).

I have not tested this further with empty schema in settings.php (whether the default public is used in this case as well), but will do it after the installation process will be working.

Not sure about the "Needs backport to D7" tag - I think, that the D7 is not working 100% correctly on schema different from public (it was not fixed unlike the D10), so probably there is no point in addressing this in D7 unless the schema usage has been fixed.