Difference between 1.x and 2.x branches

Created on 16 December 2022, over 1 year ago
Updated 16 May 2023, about 1 year ago

Problem/Motivation

A 2.x branch was opened with no disambiguation between the 1.x branch. There's no upgrade path even, but it looks like I need to install drupal_ui module?!?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ’¬ Support request
Status

Active

Version

2.0

Component

Code

Created by

heddn Nicaragua

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡΅πŸ‡±Poland pawel.traczynski Warsaw

    The jquery_ui module now hosts the entire jQuery UI library, and that the jquery_ui_datepicker module only forces inclusion of jquery_ui module in a version 1.6 which ships with the jquery ui datepicker. Beside this the version 2.0.0 of the module doesn't do anything else on it's own.

    On the other hand the jquery_ui module uses hook_library_info_alter() where it looks at what are enabled jquery ui submodules, and if specific submodule is found, then the jquery UI function is added.

    My understanding is that this is for compatibility and for other contribs to be able to add depdendencies for specific functions of the jquery ui. Anways my preference would be to rather enable jquery ui functions using checkboxes in the backend.

  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    the 1.x branch works with languages other than English, uses Drupals t function , and the localization framework

    Branch 2.x guts all that and relies 100% on a stripped down datepicker from the jquery_ui module assets that only has english.

  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    The 2.x branch seems like a major downgrade /regression, sacrifices a beautifully perfect localization approach for a botched approach that wasn't even attempted to be implemented.

    Can we please scrap the 2.x branch and maintain the 1.x branch and set it back as the recommended approach?

    This likely means the newest version of the jquery_ui module is botched as well.

  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    in order to use better_exposed_filters 6.0 and still maintain the superior (functioning localisation) functionality of the jquery_ui_datepicker 1.4 version I'm having to use this composer trick.
    "drupal/jquery_ui_datepicker": "1.4 as 2.0.0",

  • πŸ‡¨πŸ‡¦Canada joseph.olstad

    Ok so there is a patch available for jquery_ui that may actually substitute for the functionality that was lost between jquery_ui_datepicker 1.x and 2.x (1.x having the expected localisation functionality whereas 2.x lacking the expected localisation)

    The patch is here:
    #3339013-26: implement datepicker localisation in jquery_ui 2.x, compare with jquery_ui_datepicker 1.x that has localisation β†’

Production build 0.69.0 2024