Contrib.social

Drupal Coding Standards Issues | phpcs

Open on Drupal.org →
Created on 2 December 2022, almost 2 years ago
Updated 6 September 2024, 10 days ago

Problem/Motivation

Getting following error/warnings

FILE: /app/modules/contrib/better_exposed_filters/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
42 | WARNING | Line exceeds 80 characters; contains 94 characters
----------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/better_exposed_filters.install
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
223 | WARNING | Line exceeds 80 characters; contains 84 characters
227 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/better_exposed_filters.module
-------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------
31 | ERROR | [x] Each index in a multi-line array must be on a new line
32 | ERROR | [x] Each index in a multi-line array must be on a new line
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/includes/better_exposed_filters.theme.inc
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
162 | WARNING | '@todo' should match the format '@todo Fix problem X here.'
-------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/src/BetterExposedFiltersHelper.php
------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------
46 | ERROR | [x] list(...) is forbidden, use [...] instead.
80 | WARNING | [ ] Unused variable $value.
80 | WARNING | [ ] Unused variable $value.
83 | WARNING | [ ] Unused variable $value.
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/src/Plugin/BetterExposedFiltersWidgetBase.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
159 | WARNING | Unused bound variable $form.
159 | WARNING | Unused bound variable $element.
-----------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/src/Plugin/better_exposed_filters/filter/DatePickers.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
41 | WARNING | [ ] Unused variable $element.
110 | WARNING | [x] '@todo: To be honest, I'm not sure this is needed. Can you set a' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/src/Plugin/better_exposed_filters/filter/FilterWidgetBase.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------
116 | WARNING | [ ] Only string literals should be passed to t() where possible
185 | WARNING | [ ] Only string literals should be passed to t() where possible
251 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
258 | ERROR | [x] Expected newline after closing brace
259 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/src/Plugin/better_exposed_filters/filter/Single.php
-----------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
61 | ERROR | [x] Use null coalesce operator instead of ternary operator.
61 | ERROR | [x] Use null coalesce operator instead of ternary operator.
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/src/Plugin/views/exposed_form/BetterExposedFilters.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
924 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
925 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/tests/src/FunctionalJavascript/BetterExposedFiltersTest.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------
79 | WARNING | Unused variable $display.
135 | WARNING | Unused variable $display.
136 | WARNING | Unused variable $block.
192 | WARNING | Unused variable $display.
-------------------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/tests/src/Kernel/BetterExposedFiltersKernelTest.php
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------
26 | WARNING | Unused variable $display.
51 | WARNING | Unused variable $display.
-----------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/filter/FilterWidgetKernelTest.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------
81 | WARNING | Unused variable $display.
125 | WARNING | Unused variable $display.
-----------------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/filter/HiddenFilterWidgetKernelTest.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $display.
-----------------------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/filter/SingleFilterWidgetKernelTest.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $display.
-----------------------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/sort/LinksSortWidgetKernelTest.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $display.
------------------------------------------------------------------------------------------------------------

FILE: /app/modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/sort/RadioButtonsSortWidgetKernelTest.php
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $display.
-------------------------------------------------------------------------------------------------------------------

Time: 4.69 secs; Memory: 18MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/better_exposed_filters/

Proposed resolution

Above error/warnings need to be fixed

🐛 Bug report
Status

Closed: duplicate

Version

6.0

Component

Code

Created by

🇮🇳India samit.310@gmail.com

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024