Smart date recurring compatibility

Created on 30 November 2022, about 2 years ago
Updated 29 January 2023, almost 2 years ago

Problem/Motivation

Add an event using smart date and recurring events.

When adding the exposed filter the event shows up but it adds one item per entry.
I even tried to add the date and set it to create a new row per delta and that did not work.

Steps to reproduce

Install smart date
Add smart date field type
Set to unlimited
Check recurring dates on the field settings

Create a piece of content with a recurring rule.

Create view on that using calendar views
Add the start for the field you created as an exposed filter

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States nicxvan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • @matthieuscarset opened merge request.
  • Status changed to Needs review almost 2 years ago
  • πŸ‡¨πŸ‡¦Canada mandclu

    Based on my initial testing, this merge request is very promising. With this work applied the recurring events no longer appear more than once. I'll try to do a little more testing before moving this to RTBC.

  • Status changed to Needs work almost 2 years ago
  • πŸ‡¨πŸ‡¦Canada mandclu

    There is some progress, but we're not quite there yet. The work in this branch prevents multiple values from each being displayed for every value, but based on my testing it only ever displays the first value. This is true whether the values are recurring, or simply multiple, non-recurring values.

  • πŸ‡¨πŸ‡¦Canada mandclu

    I did some more testing and realized that this does work as intended as long as the view is configured to show fields instead of rendered content, and the field is configured to not display all values in the same row.

    Leaving the issue as "needs work" because the MR looks like it needs to be manually rebased.

  • Status changed to Needs review almost 2 years ago
  • TY very much for testing and for your feedback @mandclu @nicxvan

    It helped me clarify the issue and I learned more about Smart Date module too πŸ˜„

    I made small changes to the processing of View results in this MR and it seems to work correctly - at least from my own tests.

    These changes needs more review before I can merge them and release a new version.

    Looking forward to hearing from you.

  • Status changed to RTBC almost 2 years ago
  • πŸ‡¨πŸ‡¦Canada mandclu

    Just tested this again (with the latest commits) and it's still working great for me, with both core multivalued fields and Smart Date recurring values.

    In testing I did find something slightly odd (to me, anyway) about the navigation by month pager, but I'll file a separate ticket for that.

    IMHO this needs documentation, particularly because it requires a very specific setup to work. Happy to document this in the Smart Date handbook, but it might be worth including in this module's README as well.

  • Status changed to Fixed almost 2 years ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024