Resolve phpcs errors

FILE: .../drupal/web/modules/contrib/broadstreet_ads/broadstreet-ad-message.tpl.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...l_9.4/drupal/web/modules/contrib/broadstreet_ads/broadstreet_ads.admin.inc -------------------------------------------------------------------------------- FOUND 52 ERRORS AND 8 WARNINGS AFFECTING 54 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank | | line 13 | ERROR | [ ] Comment indentation error, expected only 1 spaces 15 | WARNING | [ ] Line exceeds 80 characters; contains 169 characters 20 | ERROR | [ ] Comment indentation error, expected only 1 spaces 23 | WARNING | [x] There must be no blank line following an inline comment 23 | WARNING | [ ] There must be no blank line following an inline comment 23 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses 25 | ERROR | [x] Short array syntax must be used to define arrays 33 | ERROR | [x] Short array syntax must be used to define arrays 37 | ERROR | [x] Short array syntax must be used to define arrays 42 | ERROR | [x] Short array syntax must be used to define arrays 47 | ERROR | [x] Short array syntax must be used to define arrays 54 | ERROR | [x] Short array syntax must be used to define arrays 55 | ERROR | [x] Short array syntax must be used to define arrays 59 | ERROR | [x] Short array syntax must be used to define arrays 69 | ERROR | [x] Short array syntax must be used to define arrays 70 | ERROR | [x] Short array syntax must be used to define arrays 74 | ERROR | [x] Short array syntax must be used to define arrays 80 | ERROR | [x] Short array syntax must be used to define arrays 81 | ERROR | [x] Short array syntax must be used to define arrays 85 | ERROR | [x] Short array syntax must be used to define arrays 94 | ERROR | [ ] The array declaration extends to column 144 (the limit is | | 80). The array content should be split up over multiple | | lines 94 | ERROR | [x] Short array syntax must be used to define arrays 95 | ERROR | [x] Short array syntax must be used to define arrays 102 | ERROR | [x] Short array syntax must be used to define arrays 106 | WARNING | [x] A comma should follow the last multiline array item. | | Found: ) 108 | ERROR | [x] Short array syntax must be used to define arrays 111 | ERROR | [x] Short array syntax must be used to define arrays 120 | ERROR | [x] Short array syntax must be used to define arrays 125 | ERROR | [x] Short array syntax must be used to define arrays 126 | ERROR | [x] Short array syntax must be used to define arrays 127 | ERROR | [x] Short array syntax must be used to define arrays 131 | ERROR | [x] Short array syntax must be used to define arrays 136 | ERROR | [x] Short array syntax must be used to define arrays 137 | ERROR | [x] Short array syntax must be used to define arrays 138 | ERROR | [x] Short array syntax must be used to define arrays 142 | ERROR | [x] Short array syntax must be used to define arrays 144 | ERROR | [x] Short array syntax must be used to define arrays 145 | ERROR | [x] Short array syntax must be used to define arrays 146 | ERROR | [x] Short array syntax must be used to define arrays 150 | ERROR | [x] Short array syntax must be used to define arrays 159 | ERROR | [x] Short array syntax must be used to define arrays 165 | ERROR | [x] Short array syntax must be used to define arrays 172 | ERROR | [x] Short array syntax must be used to define arrays 178 | ERROR | [x] Short array syntax must be used to define arrays 182 | ERROR | [x] Short array syntax must be used to define arrays 186 | ERROR | [x] Short array syntax must be used to define arrays 187 | ERROR | [x] Short array syntax must be used to define arrays 216 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 216 | WARNING | [x] There must be no blank line following an inline comment 216 | WARNING | [ ] There must be no blank line following an inline comment 216 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses 241 | ERROR | [x] Short array syntax must be used to define arrays 242 | ERROR | [x] Use null coalesce operator instead of ternary operator. 243 | ERROR | [x] Use null coalesce operator instead of ternary operator. 259 | ERROR | [x] Short array syntax must be used to define arrays 263 | WARNING | [ ] Unused variable $key. 299 | ERROR | [x] Short array syntax must be used to define arrays 302 | ERROR | [x] Short array syntax must be used to define arrays 307 | ERROR | [x] Short array syntax must be used to define arrays -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 52 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...rupal_9.4/drupal/web/modules/contrib/broadstreet_ads/src/Form/Settings.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 8 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...upal/web/modules/contrib/broadstreet_ads/src/Plugin/Derivative/AdBlock.php -------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------- 2 | ERROR | [x] Whitespace found at end of line 11 | ERROR | [x] Whitespace found at end of line 24 | ERROR | [x] list(...) is forbidden, use [...] instead. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...upal_9.4/drupal/web/modules/contrib/broadstreet_ads/broadstreet-ad.tpl.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 1.91 secs; Memory: 12MB

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States DamienMcKenna NH, USA
The codebase was heavily modified recently, so this needed to be redone.
Comment over 1 year ago →
🇺🇸United States DamienMcKenna NH, USA
Comment over 1 year ago →
🇺🇸United States DamienMcKenna NH, USA
Comment over 1 year ago →
🇮🇳India Nayana Ramakrishnan
nayana_mvr → made their first commit to this issue’s fork.
@nayana_mvr opened merge request.
Comment over 1 year ago →
System Message
The last submitted patch, 4: broadstreet_ads-n3324397-4.patch, failed testing. View results →
Comment over 1 year ago →
System Message

DamienMcKenna → committed 91ea0425 on 2.0.x
Issue #3324397 by nayana_mvr, Rohit Rana, DamienMcKenna: Coding...
Status changed to Fixed over 1 year ago6:35pm 7 March 2023
Comment over 1 year ago →
🇺🇸United States DamienMcKenna NH, USA
Committed.

Note - the merge request was unnecessary, but I'll give you credit for it anyway.
Comment over 1 year ago →
System Message
DamienMcKenna → closed merge request !1
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Problem/Motivation

Comments & Activities