Hide signature file reference if not used

Here is a small patch we wrote to add a setting to enable the display of the signature file.

There are probably more elegant ways to write this, such as:

1. Doing a file_exists check.
2. Changing the logic to be disable_signature instead of enable_signature. As this patch is written now, a database update hook would be required before merging this into the branch. That said, it was a quick way for our team to solve this.

Hoping this helps folks for now. We might pick this back up to improve the patch if the maintainers seem interested in merging at some point + offer up guidance as to what their preferred implementation is. Cheers!

Thanks! I haven't tested but I took a quick look and it seems fine other than this minor nitpick below. Note that you should move the issue to "Needs review" after providing a patch/MR so that people know to review the code and manual test.

1. +++ b/src/Form/SecuritytxtConfigureForm.php
   @@ -178,6 +186,7 @@ class SecuritytxtConfigureForm extends ConfigFormBase {
          ->set('enabled', $enabled)
   +      ->set('enabled_signature', $enabled_signature)    ¶
   

   Extraneous spaces at the end of the line

2. +++ b/src/SecuritytxtSerializer.php
   @@ -27,6 +27,7 @@ class SecuritytxtSerializer {
        $contact_email = $settings->get('contact_email');
   

   Extraneous spaces at the end of the line

Here is the updated patch along with few other phpcs fixes.

The additional phpcs fixes make this a little harder to review, but code looks good and works for me.

Thank you! Committed! 🍻

Automatically closed - issue fixed for 2 weeks with no activity.