- last update
over 1 year ago Composer error. Unable to continue. - last update
over 1 year ago Composer require failure - last update
over 1 year ago 26 pass - Status changed to Needs work
8 months ago 3:02pm 24 June 2024 - 🇺🇸United States smustgrave
New config key will need schema update and post_update hook.
- Merge request !20Allow setting CSS classes to force certain links inside them to behave as external → (Merged) created by vidorado
- 🇺🇸United States smustgrave
Question how come "Only look for links inside these CSS selectors." does meet the case?
- 🇪🇸Spain vidorado Logroño (La Rioja)
We had a content type whose links must open in a new tab, even though they would be considered internal, as they pointed to the same site pages.
The case this feature solved for us was forcing some links to behave as external, even when they were not.
I hope it makes sense to you now! :)
- 🇺🇸United States smustgrave
Will have to think about that, module scope is to cover external links which sounds like is not the case it's trying to be used for.
- 🇪🇸Spain vidorado Logroño (La Rioja)
Think about it like "another config to allow the user to solve its needs". Maybe my use case is a bit kind of weird but, in my opinion, It should not harm giving the user a complete include/exclude logic toolset.
Whatever you decide, I'm sure it will be ok :)
- 🇺🇸United States smustgrave
So there are other issues trying to get into the 2.0.x beta release. But if this one is worked on and doesn't break anything I'm not opposed to it. Will need test coverage and MR updated for 2.0.x
- 🇪🇸Spain vidorado Logroño (La Rioja)
vidorado → changed the visibility of the branch 8.x-1.x to hidden.
- 🇪🇸Spain vidorado Logroño (La Rioja)
Sorry for the flooding! (my first MR 😅)
I didn't managed to resolve a PHPUnit test issue in the pipeline. In my local environment all tests are passing.
- 🇪🇸Spain vidorado Logroño (La Rioja)
@smustgrave, I figured the problem out :)
All tests passing on Drupalcode!
- Status changed to Fixed
8 months ago 3:17pm 28 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.