Compatibility with rector 0.13.10+

I was able to get around this error by simply updating the upgrade_rector/rector-config-template.php with the following code:

<?php

declare(strict_types=1);

use DrupalRector\Set\Drupal8SetList;
use DrupalRector\Set\Drupal9SetList;
use Rector\Config\RectorConfig;

return static function (RectorConfig $rectorConfig): void {
  // Adjust the set lists to be more granular to your Drupal requirements.
  // @todo find out how to only load the relevant rector rules.
  //   Should we try and load \Drupal::VERSION and check?
  $rectorConfig->sets([
    Drupal8SetList::DRUPAL_8,
    Drupal9SetList::DRUPAL_9,
  ]);

  $parameters = $rectorConfig->parameters();
  $rectorConfig->autoloadPaths([
    $drupal_root . '/core',
    $drupal_root . '/modules',
    $drupal_root . '/profiles',
    $drupal_root . '/themes'
  ]);

  $rectorConfig->skip(['*/upgrade_status/tests/modules/*']);
  $rectorConfig->fileExtensions(['php', 'module', 'theme', 'install', 'profile', 'inc', 'engine']);
  $rectorConfig->importNames(true, false);
  $rectorConfig->importShortClasses(false);
  $parameters->set('drupal_rector_notices_as_comments', true);
};

This mimics vendor/palantirnet/drupal-rector/rector.php, with only difference it doesn't use DrupalFinder.
If I read the results of this correctly - it works.

Here is what I got for the Redirect 8.x-1.7 module.

Rector log:

20/105 [▓▓▓▓▓░░░░░░░░░░░░░░░░░░░░░░░]  19%[1G[2K  40/105 [▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░░░]  38%[1G[2K  60/105 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░]  57%[1G[2K  65/105 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░]  61%[1G[2K  85/105 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░]  80%[1G[2K 105/105 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
=====================

 [OK] 30 files would have changed (dry-run) by Rector

Applied Rectors:

• DrupalGetPathRector
• ArgumentRemoverRector
• GetMockBuilderGetMockToCreateMockRector (https://github.com/lmc-eu/steward/pull/187/files#diff-c7e8c65e59b8b4ff8b...)
• RenameClassRector
• WrapReturnRector
• ChangeMethodVisibilityRector
• AssertFieldByNameRector
• ProtectedStaticModulesPropertyRector ( https://www.drupal.org/node/2909426 → )
• AddReturnTypeDeclarationRector
• AssertIdenticalRector
• PassRector
• AssertLinkRector
• AssertRawRector
• AssertUrlRector
• UiHelperTraitDrupalPostFormRector
• AssertLinkByHrefRector
• AssertResponseRector
• AssertTextRector
• AssertNoOptionRector
• AssertOptionByTextRector
• AssertOptionRector
• AssertNoRawRector
• AssertElementPresentRector
• AssertNoTextRector
• AssertOptionSelectedRector
• RenameMethodRector

And it successfully generated a very long patch.

Here is the patch.

Hi, I tested and reviewed the patch #10 and it worked. I am able to scan the modules with no errors. Here are the screenshots before and after applying the patch. Tested on upgrade_rector 8.x-1.0-alpha8 and Drupal 9.5.8

Thanks!

Updated to current rector.php state from palantir.

The last submitted patch, 12: 3322943.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

When running this still fails with

[ERROR] Class "DrupalRector\Set\Drupal10SetList" not found

Not sure how it worked for you all above?

Duh the current 0.15.1 release version does not have Drupal 10 rules yet, I pulled that from dev.

The last submitted patch, 15: 3322943.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Rectors executed does not return the FQCN anymore.

Ok this certainly fixes what the smoke tests were looking for. It still does not completely work, also has an error about not finding the form class for some reason. Let's see if naming the class namespace after the actual module name helps.

Now that passes fine, we can add extra tests that there are no errors generated either.

The last submitted patch, 19: 3322943.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Should not match a pattern when we want to match exact text.

The last submitted patch, 21: 3322943.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The values asserted were in a form, so it does not seem to appear in the page text, let's try asserting the raw values.

The last submitted patch, 23: 3322943.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Duh that's for kernel tests. Classic testbot driven development. :D

The last submitted patch, 25: 3322943.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Asserting a patch is s pain :D

All right, landed that. Its a somewhat better smoke test than we had before even.

Gábor Hojtsy → closed merge request !2

Automatically closed - issue fixed for 2 weeks with no activity.