Infinite loop when creating a menu item that links to itself

Created on 17 November 2022, almost 2 years ago
Updated 28 April 2023, over 1 year ago

Problem/Motivation

We faced an infinite loop issue on one of the sites, it turned out a menu link was linking to itself by mistake.

Steps to reproduce

  • Edit a menu item and link it that specific menu item edit form ex: /admin/structure/menu/item/31/edit
  • Grant "administer menu" to the editor role
  • login as editor
  • Observe the infinite loop

Proposed resolution

Check if the menu item's URL is the same as the menu item's canonical link to skip access check

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

πŸ› Bug report
Status

Needs work

Version

9.5

Component
Menu systemΒ  β†’

Last updated 1 day ago

Created by

πŸ‡―πŸ‡΄Jordan akhoury

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡ΏNew Zealand DanielVeza Brisbane, AU

    An alternate approach here would be to add validation logic to MenuLinkContentForm so these broken links couldn't be saved in the first place? What do people think?

Production build 0.71.5 2024