- ๐ฎ๐ณIndia Bushra Shaikh
I verified and applied MR !2 for Drupal version 10.0.2.
README.txt file updated to README.md after applying this patch. But got warning
Adding screenshots for reference.2.diff.patch:121: trailing whitespace. - Shaun Musick (Shawn2516) - https://www.drupal.org/u/shawn2516 warning: 1 line adds whitespace errors.
- Status changed to Needs work
over 1 year ago 12:49pm 1 June 2023 - Status changed to Needs review
over 1 year ago 12:54pm 1 June 2023 - ๐ฎ๐ณIndia Manoj Raj.R Chennai
Updated with latest changes.
Please review.
- Status changed to Needs work
over 1 year ago 10:27am 2 June 2023 - ๐ต๐ญPhilippines clarkssquared
Hi Manoj Raj.R
I applied your updated MR !2 to my local and confirmed that the MR applies cleanly without any whitespace error and replaced the README.txt file to README.md. But I have concern.
In this line
## InstallationViews Add Button installs like most Drupal modules:
https://www.drupal.org/docs/extending-drupal/installing-modules โI believe that it means "Install Views Add Button like most Drupal modules:"
Kindly check please,
Thank you - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:45am 2 June 2023 - Status changed to Needs work
over 1 year ago 1:27pm 2 June 2023 - ๐ต๐ญPhilippines clarkssquared
Hi nitin_lama
I applied the updated MR !2 in freshly installed Views Add Button module and confirmed that the README content is now good, but the file doesn't change from .txt to .md file
Please look at the screenshot attached for your reference
Thank you
- ๐บ๐ธUnited States laboratory.mike
laboratory.mike โ made their first commit to this issueโs fork.
-
laboratory.mike โ
committed 1bc117fd on 2.0.x authored by
Manoj Raj.R โ
Issue #3321567 by Manoj Raj.R, nitin_lama, laboratory.mike,...
-
laboratory.mike โ
committed 1bc117fd on 2.0.x authored by
Manoj Raj.R โ
- ๐บ๐ธUnited States laboratory.mike
@manoj-rajr it looks great, thanks.
I've merged it in, and will include in 2.0.5 .
- Status changed to Fixed
over 1 year ago 5:50pm 3 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.