- Merge request !1Issue #3321528: Replace README.txt with README.md โ (Open) created by gowthamrajkrishnasamy
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:26am 13 July 2023 - ๐ณ๐ดNorway gisle Norway
kavitha@specbee.com: Please don't upload screenshots of your terminal showing a directory tree, it just adds noise to the issue.
Before an issue can be marked RTBC the changes need to be reviewed, this wasn't done.
Please read up on Issue Etiquette โ . Pay attention on #11 and #14 on the "Don't" list.
Your comment here is spam. I'm setting the status back to "Needs review".
- ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!1, the patch is not cleanly applied.
1. Change "## Contents of this file" to "## Table of contents".
- Status changed to Needs work
about 1 year ago 9:36am 16 October 2023 - ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- Status changed to Needs review
11 months ago 10:49am 21 December 2023 - Status changed to Needs work
11 months ago 9:44am 9 January 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!1, the patch is not cleanly applied.
1. In the requirement section and Maintainer section, hyphen (-) is not required as there is no list. Only a single statement is there,
- Status changed to Needs review
10 months ago 12:59pm 31 January 2024 - ๐ฎ๐ณIndia Anjali Mehta
@Nupur Badola, please carefully review the MR and highlight only the necessary changes according to the Drupal Readme.md template. โ Regarding your comment, there is no need for this change:
In the Maintainers and Requirements section, only one maintainer/requirement is given, so the hyphen (-) is not required.
Since this section is titled "Maintainers or Requirements" even when there is a single maintainer , the content of this section can be a list of maintainers or requirements, even in the case where there is just a single maintainer.
Since the last reviewer does not pay much attention to details, it would be better somebody else reviews the MR.
- Status changed to Needs work
10 months ago 7:53am 1 February 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi Anjali Mehta
I reviewed MR!1 and noticed that the configuration section "Goto" text is not correct to use in configuration, not quite sure what word can be replaced to 'Goto' to have better readability. And also on "Introduction and project name" section the text
.This module
has no spacing after the dot.Thank you.
- Status changed to Needs review
10 months ago 10:02am 1 February 2024