Fix PHP coding standards (Code style issue)

Open on Drupal.org →

Created on 15 November 2022, about 2 years ago

Updated 14 February 2023, almost 2 years ago

FILE: string/drupalci.yml
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: string/README.md (IGNORED, because fix for README was done https://www.drupal.org/project/string/issues/3302369 📌 t() calls should be avoided in classes Fixed )
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 14 WARNINGS AFFECTING 14 LINES
------------------------------------------------------------------------------------------------------------
4 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
22 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
24 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters
28 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
29 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
32 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
42 | WARNING | [ ] Line exceeds 80 characters; contains 210 characters
90 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
98 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
100 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
104 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
108 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
119 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
126 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
126 | ERROR | [x] Expected 1 newline at end of file; 3 found
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

FILE: string/modules/string_demo/src/Controller/StringDemoController.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------
56 | ERROR | [x] Missing function doc comment
81 | ERROR | [ ] Missing short description in doc comment
82 | ERROR | [ ] Missing parameter comment
83 | ERROR | [ ] Missing parameter comment
83 | ERROR | [ ] Missing parameter type
84 | ERROR | [ ] Missing parameter comment
85 | ERROR | [ ] Missing parameter comment
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: string/modules/string_i18next/string_i18next.services.yml
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: string/modules/string_i18next/src/Plugin/rest/resource/StringCollectionResource.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Doc comment short description must end with a full stop
24 | ERROR | [ ] Missing short description in doc comment
66 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
66 | ERROR | [ ] Description for the @return value is missing
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: string/modules/string_i18next/src/Plugin/rest/resource/StringResource.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Doc comment short description must end with a full stop
24 | ERROR | [ ] Missing short description in doc comment
66 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
66 | ERROR | [ ] Description for the @return value is missing
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: string/modules/string_i18next/src/StringI18Next.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
16 | ERROR | [ ] Missing short description in doc comment
21 | ERROR | [ ] Missing short description in doc comment
26 | ERROR | [x] Missing function doc comment
31 | ERROR | [x] Missing function doc comment
55 | ERROR | [x] Missing function doc comment
63 | ERROR | [x] Missing function doc comment
82 | WARNING | [ ] Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------

FILE: string/src/Form/StringSettingsForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------------
78 | ERROR | Missing short description in doc comment
79 | ERROR | Description for the @return value is missing
102 | ERROR | The array declaration extends to column 109 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------

FILE: string/src/Form/ExportForm.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------
201 | ERROR | [x] Missing function doc comment
209 | ERROR | [x] Missing function doc comment
220 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: string/src/StringManager.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
33 | ERROR | [ ] Missing short description in doc comment
71 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: string/src/Translator/StringTranslationDefaults.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Doc comment long description must end with a full stop
29 | ERROR | [ ] Missing short description in doc comment
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇦Ukraine Anna D

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇩🇪Germany D34dMan Hamburg
I don't see any bug report in here, hence converting it to Task.

Patch in #13 would introduce a bug though (thanks Anna for noticing it). So the state as in #10 seems to be good enough to go in. Probably we need to silence the error on line 98 instead of trying to fix it.

Can anybody create a MR based on #10?
Assigned to Sonal Gyanani
Comment almost 2 years ago →
🇮🇳India Sonal Gyanani
Issue was unassigned.
Status changed to Needs review almost 2 years ago5:57am 27 January 2023
Comment almost 2 years ago →
🇮🇳India Sonal Gyanani
Status changed to Fixed almost 2 years ago6:52am 14 February 2023
Comment almost 2 years ago →
🇩🇪Germany D34dMan Hamburg
Thanks for the contribution everybody. Since multiple issues and branches were working on fixing coding style fixes, I went ahead and did that in my local. Nonetheless, will credit everybody in this issue queue.
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024