Make build tests fail 1) more explicitly, 2) earlier when possible (failing StatusCheckEvent subscribers)

Actually, I think I already wrote everything that we need here … I was forced to do so in 📌 Limit trusted Composer plugins to a known list, allow user to add more Fixed .

See #3331168-13: Limit trusted Composer plugins to a known list, allow user to add more → through #3331168-17: Limit trusted Composer plugins to a known list, allow user to add more → and all commits + comments in between.

Verifying that now…

I thought, but I was wrong!

The scope of this issue is to check StatusCheckEvent before starting the whole build process test (or at least as early as possible).

In 📌 Limit trusted Composer plugins to a known list, allow user to add more Fixed , I did improve build test coverage relating to validation and in principle also around StatusCheckEvent. But:

• it aimed to improve the DX of build tests by not failing in obfuscated ways, by surfacing the actual error messages on the visited pages during the build test ⇒ during, not before/early
• it aimed to do so for all events, not just status check events

Opening a new issue…

Hah, just discussed with @tedbow, and he actually wants to expand the scope of this issue slightly because there is a lot of overlap in the code needed for the current scope and what I did over there 😄🎉

Bringing over the relevant pieces from 📌 Limit trusted Composer plugins to a known list, allow user to add more Fixed in a new MR.

The new branch was ~2 months behind because that's when the issue fork was created … so first caught it up to current 8.x-2.x.

Brought over the 4 essential commits from 📌 Limit trusted Composer plugins to a known list, allow user to add more Fixed . Tests pass locally 👍

But … ModuleUpdateTest fails locally. I was hoping to only have to modify that test in 📌 Limit trusted Composer plugins to a known list, allow user to add more Fixed , but it looks like the improved error checking in Build tests show that this is actually pseudo-broken in HEAD — HEAD just happens to ignore the error message 😅

Let's see if DrupalCI confirms that finding …

Looks like ModuleUpdateTest passes on 10.0.x. But I'm fairly certain it'll fail on 9.5.x. Queued test for that. See #3331168-17: [PP-1] Limit trusted Composer plugins to a known list, allow user to add more → for the analysis behind that statement.

Well … okay … I don't understand this, but for some reason it's passing. Okay. Yay for a smaller/simpler set of changes here then! 😄

As discussed, back to you, @tedbow, to extract part of what I did and run it automatically at the start of each build test! 😊

Ok brought in my changes into 3320792-explicit-early .

1 test failed but I pushed up a fix for it

Created 📌 Assert no errors after creating the test project in ModuleUpdateTest Needs review as a follow up but that issue is tagged contrib-only so I am not adding the sprint tag since we don't need to do it now.

I would really like to get this in and I don't think the functional test are going to share that much code so I rescoping this the orignal

We could use the same code in functional test like I did in the original MR https://git.drupalcode.org/issue/automatic_updates-3320792/-/blob/332079...

but I think that is overkill for the functional tests to rely on the UI when I think all we have to do in functional test is to use our existing function like
$this->assertStatusCheckResults([]);

We just have to figure where to call because some functional test are step up to specifically fail status checks and other don't enable automatic_updates until later so calling
$this->assertStatusCheckResults([]); would only assert package_manager validators

and we can't simply enable automatic updates , $this->assertStatusCheckResults([]); and then disable it because some test what happens when we enable automatic_updates so doing this would change test coverage.

TLDR I don't want to figure all that out right now and put off the fix for build tests.

Created follow-up 📌 Assert status checks pass as early as possible in kernel and functional tests Closed: outdated

Let's ship this! 🚢

This is definitely a net improvement, and all your changes make sense to me 👍

`composer phpcs` ran locally

merged 8.x-2.x , will commit when green

tedbow → closed merge request !587

🎉

Automatically closed - issue fixed for 2 weeks with no activity.