Contrib.social

Add support to enable Varbase Media Header on Taxonomy Terms entity type

Open on Drupal.org →
Created on 8 November 2022, over 1 year ago
Updated 7 September 2023, 10 months ago

Problem/Motivation

We can add the media header only on contents types, so when I tried to add a media header on the term page I couldn't do it, so I handled to add a media header on the term page

Steps to reproduce

No fields will be added to the taxonomy, if we add the field manually we will need to include the template and block manually

Proposed resolution

  • Add a new entity option, which is a Taxonomy term, with a node entity with some enhancement.
              // Planed for allowed entity types to have node, taxonomy.
          // more other entity types if needed.
          $allowed_entity_types = ['node', 'taxonomy_term'];
  • Refine the code logic for constructing the block by ensuring a more organized order.
  • Implement efficient block cache context and logic management.
  • Group bundles for supported entity types to improve code structure and maintainability.
  • Import managed Entity Type configs for supported entity types. Only when needed.

As a test Example:
The varbase_media_header.settings.yml schema and configs looks as the following when enabled for page, varbase_blog content types and blog_categories terms:

varbase_media_header_settings:
  node:
    page: page
    varbase_blog: varbase_blog
    landing_page_lb: 0
    varbase_heroslider_media: 0
  taxonomy_term:
    blog_categories: blog_categories
    tags: 0
hide_breadcrumbs: false

That is covered with the same config schema

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ✅ Developer Documentation support on feature change/addition
    Changed for Varbase ~9.0.0
    Configuring Varbase Media Header
    Changed for Varbase ~10.0.0
    Configuring Varbase Media Header
  • ✅ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-9.0.15 → , varbase_media_header-9.0.6 → , varbase-10.0.0-beta1, varbase_media_header-10.0.0-alpha1 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

Varbase Media Header Settings
→

Configure block - Varbase Media Header
→

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

✨ Feature request
Status

Fixed

Version

9.0

Component

Code

Created by

🇯🇴Jordan YazanMajadba

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024