Warmer should not run multiple times for the same image

@Odai Atieh: The problem with module weight of the Image Style Warmer module should be already solved in the 8.x-1.2-rc1. Maybe you could double check with this RC1 if some of your problems are already solved.

Set to needs review to see what happens during PHP unit testing when crop module is not enabled.

Adding the correct tag got Drupal Global Contribution Weekend 2023.

Re-roll Patch to be working with the latest version

We should add testing of Image Style Warmer with enabled Crop API contrib module.

Steps to do:

• Add drupal/crop as dev reequirement to composer.json
• Clone existing related tests with enabled crop module

I think there is something wrong with tests, because the patch/MR has this:

/**
 * Implements hook_ENTITY_update() for crop entity.
 */
function image_style_warmer_entity_update(EntityInterface $entity) {
  if (!\Drupal::service('module_handler')->moduleExists('crop')) {
    return;
  }
...
  \Drupal::service('image_style_warmer.warmer')->warmUp()

so when crop module is not installed \Drupal::service('image_style_warmer.warmer')->warmUp() is never called and image styles should not be generated. The tests should catch this.

Created a test that catches the hook implementation issue I mentioned on #17. The test code itself is not very clean and repeats large parts from ImageStyleWarmerTestBase.

Thanks, I think this is indeed an important issue to fix!